tools/clang/plugins/tests/weak_ptr_factory.txt - Issue 754433003: Update from https://crrev.com/305340

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/weak_ptr_factory.txt

Issue 754433003: Update from https://crrev.com/305340 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 weak_ptr_factory.cpp:35:38: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.	1 weak_ptr_factory.cpp:43:38: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

2 base::WeakPtrFactory<FactoryFirst> factory_;	2 base::WeakPtrFactory<FactoryFirst> factory_;

3 ^	3 ^

4 weak_ptr_factory.cpp:41:39: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.	4 weak_ptr_factory.cpp:49:39: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

5 base::WeakPtrFactory<FactoryMiddle> factory_;	5 base::WeakPtrFactory<FactoryMiddle> factory_;

6 ^	6 ^

7 2 warnings generated.	7 weak_ptr_factory.cpp:55:44: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	8 base::WeakPtrFactory<TwoFactoriesOneBad> factory1_;

	9 ^

	10 3 warnings generated.

OLD	NEW