Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 754433003: Update from https://crrev.com/305340 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A general interface for filtering and only acting on classes in Chromium C++ 5 // A general interface for filtering and only acting on classes in Chromium C++
6 // code. 6 // code.
7 7
8 #include "ChromeClassTester.h" 8 #include "ChromeClassTester.h"
9 9
10 #include <sys/param.h> 10 #include <sys/param.h>
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 // Because of chrome frame 199 // Because of chrome frame
200 ignored_record_names_.insert("ReliabilityTestSuite"); 200 ignored_record_names_.insert("ReliabilityTestSuite");
201 201
202 // Used over in the net unittests. A large enough bundle of integers with 1 202 // Used over in the net unittests. A large enough bundle of integers with 1
203 // non-pod class member. Probably harmless. 203 // non-pod class member. Probably harmless.
204 ignored_record_names_.insert("MockTransaction"); 204 ignored_record_names_.insert("MockTransaction");
205 205
206 // Enum type with _LAST members where _LAST doesn't mean last enum value. 206 // Enum type with _LAST members where _LAST doesn't mean last enum value.
207 ignored_record_names_.insert("ServerFieldType"); 207 ignored_record_names_.insert("ServerFieldType");
208 208
209 // Used heavily in ui_unittests and once in views_unittests. Fixing this 209 // Used heavily in ui_base_unittests and once in views_unittests. Fixing this
210 // isn't worth the overhead of an additional library. 210 // isn't worth the overhead of an additional library.
211 ignored_record_names_.insert("TestAnimationDelegate"); 211 ignored_record_names_.insert("TestAnimationDelegate");
212 212
213 // Part of our public interface that nacl and friends use. (Arguably, this 213 // Part of our public interface that nacl and friends use. (Arguably, this
214 // should mean that this is a higher priority but fixing this looks hard.) 214 // should mean that this is a higher priority but fixing this looks hard.)
215 ignored_record_names_.insert("PluginVersionInfo"); 215 ignored_record_names_.insert("PluginVersionInfo");
216 216
217 // Measured performance improvement on cc_perftests. See 217 // Measured performance improvement on cc_perftests. See
218 // https://codereview.chromium.org/11299290/ 218 // https://codereview.chromium.org/11299290/
219 ignored_record_names_.insert("QuadF"); 219 ignored_record_names_.insert("QuadF");
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location); 302 PresumedLoc ploc = source_manager.getPresumedLoc(spelling_location);
303 if (ploc.isInvalid()) { 303 if (ploc.isInvalid()) {
304 // If we're in an invalid location, we're looking at things that aren't 304 // If we're in an invalid location, we're looking at things that aren't
305 // actually stated in the source. 305 // actually stated in the source.
306 return false; 306 return false;
307 } 307 }
308 308
309 *filename = ploc.getFilename(); 309 *filename = ploc.getFilename();
310 return true; 310 return true;
311 } 311 }
OLDNEW
« no previous file with comments | « tools/android/checkstyle/chromium-style-5.0.xml ('k') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698