Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 754373002: Revert of HTML select element should return ComboBoxRole when multiple attr is not present. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of HTML select element should return ComboBoxRole when multiple attr is not present. (patchset #2 id:20001 of https://codereview.chromium.org/753123002/) Reason for revert: This CL is not required. Exposing AXComboBox on mac using the change from chromium side in this CL https://codereview.chromium.org/750933002/ Original issue's description: > HTML select element should return ComboBoxRole when multiple attr is not present. > > On mac, html select element should be exposed as > AXRole: AXComboBox > AXSubrole: <nil> > AXRoleDescription: 'combo box' > > BUG=169564 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185904 TBR=dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=169564 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
shreeramk
Created Revert of HTML select element should return ComboBoxRole when multiple attr is not present.
6 years ago (2014-11-25 13:20:00 UTC) #1
dmazzoni
lgtm
6 years ago (2014-11-25 17:24:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754373002/1
6 years ago (2014-11-25 17:25:18 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-25 17:25:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185956

Powered by Google App Engine
This is Rietveld 408576698