Issue 754373002: Revert of HTML select element should return ComboBoxRole when multiple attr is not present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 754373002: Revert of HTML select element should return ComboBoxRole when multiple attr is not present. (Closed)

Created:
6 years ago by shreeramk

Modified:
6 years ago

Reviewers:
dmazzoni

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of HTML select element should return ComboBoxRole when multiple attr is not present. (patchset #2 id:20001 of https://codereview.chromium.org/753123002/) Reason for revert: This CL is not required. Exposing AXComboBox on mac using the change from chromium side in this CL https://codereview.chromium.org/750933002/ Original issue's description: > HTML select element should return ComboBoxRole when multiple attr is not present. > > On mac, html select element should be exposed as > AXRole: AXComboBox > AXSubrole: <nil> > AXRoleDescription: 'combo box' > > BUG=169564 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185904 TBR=dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=169564 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185956

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	Source/modules/accessibility/AXNodeObject.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

shreeramk

Created Revert of HTML select element should return ComboBoxRole when multiple attr is not present.

6 years ago (2014-11-25 13:20:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754373002/1

6 years ago (2014-11-25 17:25:18 UTC) #4

commit-bot: I haz the power

6 years ago (2014-11-25 17:25:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185956