Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 754363002: Add DumpAccessibilityTree tests (16 of 20) (Closed)

Created:
6 years ago by ramya.v
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (16 of 20) ARIA Role: directory, slider, tooltip, treegrid ARIA state/property: aria-multiline BUG=170588 Committed: https://crrev.com/3c19b965a0fbd629143a6afca7b04d6894954cd2 Cr-Commit-Position: refs/heads/master@{#306160}

Patch Set 1 #

Patch Set 2 : Uploading expectation files #

Total comments: 1

Patch Set 3 : Incorporating review comments #

Patch Set 4 : Allowing name to display in test expectations for treegrid.html #

Patch Set 5 : Adding name to AUTHORS list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -13 lines) Patch
M AUTHORS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 4 chunks +21 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-directory.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/aria-directory-expected-android.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
A content/test/data/accessibility/aria-directory-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-directory-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-multiline.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/aria-multiline-expected-android.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-multiline-expected-mac.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-multiline-expected-win.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria-slider.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-slider-expected-android.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-slider-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-slider-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-tooltip.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-tooltip-expected-android.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download
A content/test/data/accessibility/aria-tooltip-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-tooltip-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-treegrid.html View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-treegrid-expected-android.txt View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
A content/test/data/accessibility/aria-treegrid-expected-mac.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-treegrid-expected-win.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
ramya.v
Please Review. Thanks
6 years ago (2014-11-26 05:43:23 UTC) #2
ramya.v
On 2014/11/26 05:43:23, ramya.v wrote: > Please Review. Thanks @dmazzoni Can you please review the ...
6 years ago (2014-11-27 04:54:48 UTC) #3
dmazzoni
Great aside from treegrid https://codereview.chromium.org/754363002/diff/20001/content/test/data/accessibility/aria-treegrid.html File content/test/data/accessibility/aria-treegrid.html (right): https://codereview.chromium.org/754363002/diff/20001/content/test/data/accessibility/aria-treegrid.html#newcode10 content/test/data/accessibility/aria-treegrid.html:10: <div role="treegrid"></div> I don't think ...
6 years ago (2014-11-27 07:37:53 UTC) #4
ramya.v
On 2014/11/27 07:37:53, dmazzoni wrote: > Great aside from treegrid > > https://codereview.chromium.org/754363002/diff/20001/content/test/data/accessibility/aria-treegrid.html > File ...
6 years ago (2014-11-27 08:49:37 UTC) #5
ramya.v
On 2014/11/27 08:49:37, ramya.v wrote: > On 2014/11/27 07:37:53, dmazzoni wrote: > > Great aside ...
6 years ago (2014-11-28 05:30:17 UTC) #6
dmazzoni
lgtm
6 years ago (2014-11-29 07:49:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754363002/60001
6 years ago (2014-11-29 07:50:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27205)
6 years ago (2014-11-29 07:55:06 UTC) #11
ramya.v
On 2014/11/29 07:55:06, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-01 04:53:19 UTC) #12
dmazzoni
lgtm
6 years ago (2014-12-01 06:45:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754363002/80001
6 years ago (2014-12-01 06:46:09 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-01 07:45:49 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-01 07:46:35 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3c19b965a0fbd629143a6afca7b04d6894954cd2
Cr-Commit-Position: refs/heads/master@{#306160}

Powered by Google App Engine
This is Rietveld 408576698