src/compiler.cc - Issue 754303003: Flesh out vector ic state query and set mechanisms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 754303003: Flesh out vector ic state query and set mechanisms. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comment response. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 82412a3b16a0b5ba30672d08adbab1dc805e0f20..b068ee5bbe7789429a55ec50e90beb5957833730 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -297,10 +297,8 @@ void CompilationInfo::PrepareForCompilation(Scope* scope) {

void CompilationInfo::EnsureFeedbackVector() {

if (feedback_vector_.is_null()) {

feedback_vector_ = isolate()->factory()->NewTypeFeedbackVector(

- function()->slot_count(), function()->ic_slot_count());

+ function()->feedback_vector_spec());

}

- DCHECK(feedback_vector_->Slots() == function()->slot_count() &&

- feedback_vector_->ICSlots() == function()->ic_slot_count());

}