Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 75423002: Minor clean-up of Type::Print (Closed)

Created:
7 years, 1 month ago by rossberg
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Minor clean-up of Type::Print R=verwaest@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=18010

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -52 lines) Patch
M src/types.h View 5 chunks +6 lines, -34 lines 0 comments Download
M src/types.cc View 1 2 chunks +28 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
7 years, 1 month ago (2013-11-18 16:35:11 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/75423002/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/75423002/diff/1/src/types.cc#newcode548 src/types.cc:548: for (unsigned i = 0; i ...
7 years, 1 month ago (2013-11-18 17:05:45 UTC) #2
rossberg
PTAL https://codereview.chromium.org/75423002/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/75423002/diff/1/src/types.cc#newcode548 src/types.cc:548: for (unsigned i = 0; i < sizeof(bitset)*8; ...
7 years, 1 month ago (2013-11-18 17:37:03 UTC) #3
rossberg
7 years, 1 month ago (2013-11-22 12:38:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18010 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698