Add ChildPortServer, a MachMessageServer::Interface implementation for the child_port subsystem

Add ChildPortServer, a MachMessageServer::Interface implementation for
the child_port subsystem.

Common routines shared with the ExcServer family of classes have been
moved to a new file, where they can be shared between different
MachMessageServer::Interface implementations.

TEST=util_test ChildPortServer.*:MachMessageUtil.*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/04aaa36026c1b625146541b91467ea651a8b7c7e

[Mark Mentovai, 2014-11-24 20:19:19]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-11-24 20:19:20]

This depends on https://codereview.chromium.org/752243002/.

[Robert Sesek, 2014-11-25 14:48:25]

https://codereview.chromium.org/754123002/diff/1/util/mach/child_port_server.cc
File util/mach/child_port_server.cc (right):

https://codereview.chromium.org/754123002/diff/1/util/mach/child_port_server....
util/mach/child_port_server.cc:26: // with the standard mach_msg_server()
function calls out to this functions.
nit: functions. (extra 's')

https://codereview.chromium.org/754123002/diff/1/util/mach/child_port_server.h
File util/mach/child_port_server.h (right):

https://codereview.chromium.org/754123002/diff/1/util/mach/child_port_server....
util/mach/child_port_server.h:52: explicit ChildPortServer(Interface*
interface);
Document the parameter ownership.

https://codereview.chromium.org/754123002/diff/1/util/mach/mig.cc
File util/mach/mig.cc (right):

https://codereview.chromium.org/754123002/diff/1/util/mach/mig.cc#newcode17
util/mach/mig.cc:17: namespace crashpad {
This file could have a trivial test.

[Mark Mentovai, 2014-11-25 17:26:38]

Patchset #2 (id:20001) has been deleted

[Mark Mentovai, 2014-11-25 17:27:32]

Feedback addressed. Thanks for the review!

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
File util/mach/child_port_server_test.cc (right):

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
util/mach/child_port_server_test.cc:102: TEST(ChildPortServer,
MockChildPortCheckIn) {
I also added this bonus test.

https://codereview.chromium.org/754123002/diff/40001/util/mach/mach_message_u...
File util/mach/mach_message_util.h (right):

https://codereview.chromium.org/754123002/diff/40001/util/mach/mach_message_u...
util/mach/mach_message_util.h:15: #ifndef
CRASHPAD_UTIL_MACH_MACH_MESSAGE_UTIL_H_
I renamed this file from mig.h because I have another utility function I’d like
to add soon, MachMessageTrailerFromHeader(), and it seemed sensible to me to
group it with these functions. It didn’t work well with the MIG naming, though.

[Robert Sesek, 2014-11-25 18:56:51]

LGTM

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
File util/mach/child_port_server_test.cc (right):

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
util/mach/child_port_server_test.cc:53: void InitializeForTesting() {
Just make this the constructor instead?

[Mark Mentovai, 2014-11-25 19:29:37]

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
File util/mach/child_port_server_test.cc (right):

https://codereview.chromium.org/754123002/diff/40001/util/mach/child_port_ser...
util/mach/child_port_server_test.cc:53: void InitializeForTesting() {
Robert Sesek wrote:
> Just make this the constructor instead?

Done. I’ll also update the ExcServerVariants test in the same way in
https://codereview.chromium.org/755323002/.

[Mark Mentovai, 2014-11-25 19:29:50]

Committed patchset #3 (id:60001) manually as
04aaa36026c1b625146541b91467ea651a8b7c7e (presubmit successful).