Add Bookmark All Tabs UMA metric

Add Bookmark All Tabs UMA metric

Record all cases where this functionality is used. The existing
TabContextMenu_BookmarkAllTabs metric only records when the
functionality is invoked from the tab context menu.

BUG=

Committed: https://crrev.com/d653e4129275d63deef1c4167350962b1eb862fe
Cr-Commit-Position: refs/heads/master@{#306682}

[Mike Wittman, 2014-11-25 00:26:28]

wittman@chromium.org changed reviewers:
+ mpearson@chromium.org, sky@chromium.org

[Mike Wittman, 2014-11-25 00:26:29]

PTAL

[Mark P, 2014-11-25 04:56:21]

lgtm baring minor comments

https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:782:
UserMetricsAction("BookmarkAllTabs"));
nit: fits on one line

https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:1334: User selected Bookmark All Tabs... from
anywhere in the UI.
nit: what do you mean by "..."?  If you mean something by it, explain it,
otherwise omit it.

[sky, 2014-12-01 15:58:26]

LGTM

[Mike Wittman, 2014-12-03 20:22:38]

https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:782:
UserMetricsAction("BookmarkAllTabs"));
On 2014/11/25 04:56:21, Mark P wrote:
> nit: fits on one line

Done.

https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
tools/metrics/actions/actions.xml:1334: User selected Bookmark All Tabs... from
anywhere in the UI.
On 2014/11/25 04:56:21, Mark P wrote:
> nit: what do you mean by "..."?  If you mean something by it, explain it,
> otherwise omit it.

"Bookmark All Tabs..." is the actual text in the menu. I've removed the ellipses
to avoid confusion.

[Mike Wittman, 2014-12-03 20:23:18]

The CQ bit was checked by wittman@chromium.org

[Mike Wittman, 2014-12-03 20:23:18]

The CQ bit was unchecked by wittman@chromium.org

[Mike Wittman, 2014-12-03 20:23:19]

The CQ bit was checked by wittman@chromium.org

[commit-bot: I haz the power, 2014-12-03 20:24:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/754013006/20001

[commit-bot: I haz the power, 2014-12-03 21:46:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-03 21:48:12]

Patchset 2 (id:??) landed as
https://crrev.com/d653e4129275d63deef1c4167350962b1eb862fe
Cr-Commit-Position: refs/heads/master@{#306682}

[sky, 2014-12-03 22:14:20]

On Wed, Dec 3, 2014 at 12:22 PM,  <wittman@chromium.org> wrote:
>
>
https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
> File chrome/browser/ui/browser_commands.cc (right):
>
>
https://codereview.chromium.org/754013006/diff/1/chrome/browser/ui/browser_co...
> chrome/browser/ui/browser_commands.cc:782:
> UserMetricsAction("BookmarkAllTabs"));
> On 2014/11/25 04:56:21, Mark P wrote:
>>
>> nit: fits on one line
>
>
> Done.
>
>
https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
> File tools/metrics/actions/actions.xml (right):
>
>
https://codereview.chromium.org/754013006/diff/1/tools/metrics/actions/action...
> tools/metrics/actions/actions.xml:1334: User selected Bookmark All
> Tabs... from anywhere in the UI.
> On 2014/11/25 04:56:21, Mark P wrote:
>>
>> nit: what do you mean by "..."?  If you mean something by it, explain
>
> it,
>>
>> otherwise omit it.
>
>
> "Bookmark All Tabs..." is the actual text in the menu. I've removed the
> ellipses to avoid confusion.

You could have also wrapped the command in quotes (like you did here)
to make that clearer. But I'm fine with nuking the elipses too.

  -Scott
>
> https://codereview.chromium.org/754013006/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.