Refactor CaptureView to be defined inside an anonymous namespace.

chrome/browser/resources/net_internals/capture_view.js

Index: chrome/browser/resources/net_internals/capture_view.js
===================================================================
--- chrome/browser/resources/net_internals/capture_view.js	(revision 94867)
+++ chrome/browser/resources/net_internals/capture_view.js	(working copy)
@@ -4,98 +4,115 @@
 
 /**
  * This view displays controls for capturing network events.
- *  @constructor
  */
-function CaptureView() {
-  const mainBoxId = 'capture-view-tab-content';
-  const byteLoggingCheckboxId = 'capture-view-byte-logging-checkbox';
-  const passivelyCapturedCountId = 'capture-view-passively-captured-count';
-  const activelyCapturedCountId = 'capture-view-actively-captured-count';
-  const deleteAllId = 'capture-view-delete-all';
-  const tipAnchorId = 'capture-view-tip-anchor';
-  const tipDivId = 'capture-view-tip-div';
 
-  DivView.call(this, mainBoxId);
+var CaptureView = (function() {
+  // IDs for special HTML elements in capture_view.html
+  const MAIN_BOX_ID = 'capture-view-tab-content';
+  const BYTE_LOGGING_CHECKBOX_ID = 'capture-view-byte-logging-checkbox';
+  const PASSIVELY_CAPTURED_COUNT_ID = 'capture-view-passively-captured-count';
+  const ACTIVELY_CAPTURED_COUNT_ID = 'capture-view-actively-captured-count';
+  const DELETE_ALL_ID = 'capture-view-delete-all';
+  const TIP_ANCHOR_ID = 'capture-view-tip-anchor';
+  const TIP_DIV_ID = 'capture-view-tip-div';
 
-  var byteLoggingCheckbox = $(byteLoggingCheckboxId);
-  byteLoggingCheckbox.onclick =
-      this.onSetByteLogging_.bind(this, byteLoggingCheckbox);
+  // We inherit from DivView.
+  var superClass = DivView;
 
-  this.activelyCapturedCountBox_ = $(activelyCapturedCountId);
-  this.passivelyCapturedCountBox_ = $(passivelyCapturedCountId);
-  $(deleteAllId).onclick = g_browser.sourceTracker.deleteAllSourceEntries.bind(
-      g_browser.sourceTracker);
+  /**
+   * @constructor
+   */
+  function CaptureView() {
+    // Call superclass's constructor.
+    superClass.call(this, MAIN_BOX_ID);
 
-  $(tipAnchorId).onclick =
-      this.toggleCommandLineTip_.bind(this, tipDivId);
+    var byteLoggingCheckbox = $(BYTE_LOGGING_CHECKBOX_ID);
+    byteLoggingCheckbox.onclick =
+        this.onSetByteLogging_.bind(this, byteLoggingCheckbox);
 
-  this.updateEventCounts_();
+    this.activelyCapturedCountBox_ = $(ACTIVELY_CAPTURED_COUNT_ID);
+    this.passivelyCapturedCountBox_ = $(PASSIVELY_CAPTURED_COUNT_ID);
+    $(DELETE_ALL_ID).onclick =
+        g_browser.sourceTracker.deleteAllSourceEntries.bind(
+            g_browser.sourceTracker);
 
-  g_browser.sourceTracker.addObserver(this);
-}
+    $(TIP_ANCHOR_ID).onclick =
+        this.toggleCommandLineTip_.bind(this, TIP_DIV_ID);
 
-inherits(CaptureView, DivView);
+    this.updateEventCounts_();
 
-/**
- * Called whenever a new event is received.
- */
-CaptureView.prototype.onSourceEntriesUpdated = function(sourceEntries) {
-  this.updateEventCounts_();
-};
+    g_browser.sourceTracker.addObserver(this);
+  }
 
-/**
- * Toggles the visilibity on the command-line tip.
- */
-CaptureView.prototype.toggleCommandLineTip_ = function(divId) {
-  var n = $(divId);
-  var isVisible = n.style.display != 'none';
-  setNodeDisplay(n, !isVisible);
-  return false;  // Prevent default handling of the click.
-};
+  cr.addSingletonGetter(CaptureView);
 
-/**
- * Called whenever some log events are deleted.  |sourceIds| lists
- * the source IDs of all deleted log entries.
- */
-CaptureView.prototype.onSourceEntriesDeleted = function(sourceIds) {
-  this.updateEventCounts_();
-};
+  CaptureView.prototype = {
+    // Inherit the superclass's methods.
+    __proto__: superClass.prototype,
 
-/**
- * Called whenever all log events are deleted.
- */
-CaptureView.prototype.onAllSourceEntriesDeleted = function() {
-  this.updateEventCounts_();
-};
+    /**
+     * Called whenever a new event is received.
+     */
+    onSourceEntriesUpdated: function(sourceEntries) {
+      this.updateEventCounts_();
+    },
 
-/**
- * Called when a log file is loaded, after clearing the old log entries and
- * loading the new ones.  Returns false to indicate the view should
- * be hidden.
- */
-CaptureView.prototype.onLoadLogFinish = function(data) {
-  return false;
-};
+    /**
+     * Toggles the visilibity on the command-line tip.
+     */
+    toggleCommandLineTip_: function(divId) {
+      var n = $(divId);
+      var isVisible = n.style.display != 'none';
+      setNodeDisplay(n, !isVisible);
+      return false;  // Prevent default handling of the click.
+    },
 
-/**
- * Updates the counters showing how many events have been captured.
- */
-CaptureView.prototype.updateEventCounts_ = function() {
-  this.activelyCapturedCountBox_.textContent =
-      g_browser.sourceTracker.getNumActivelyCapturedEvents();
-  this.passivelyCapturedCountBox_.textContent =
-      g_browser.sourceTracker.getNumPassivelyCapturedEvents();
-};
+    /**
+     * Called whenever some log events are deleted.  |sourceIds| lists
+     * the source IDs of all deleted log entries.
+     */
+    onSourceEntriesDeleted: function(sourceIds) {
+      this.updateEventCounts_();
+    },
 
-/**
- * Depending on the value of the checkbox, enables or disables logging of
- * actual bytes transferred.
- */
-CaptureView.prototype.onSetByteLogging_ = function(byteLoggingCheckbox) {
-  if (byteLoggingCheckbox.checked) {
-    g_browser.setLogLevel(LogLevelType.LOG_ALL);
-  } else {
-    g_browser.setLogLevel(LogLevelType.LOG_ALL_BUT_BYTES);
-  }
-};
+    /**
+     * Called whenever all log events are deleted.
+     */
+    onAllSourceEntriesDeleted: function() {
+      this.updateEventCounts_();
+    },
 
+    /**
+     * Called when a log file is loaded, after clearing the old log entries and
+     * loading the new ones.  Returns false to indicate the view should
+     * be hidden.
+     */
+    onLoadLogFinish: function(data) {
+      return false;
+    },
+
+    /**
+     * Updates the counters showing how many events have been captured.
+     */
+    updateEventCounts_: function() {
+      this.activelyCapturedCountBox_.textContent =
+          g_browser.sourceTracker.getNumActivelyCapturedEvents();
+      this.passivelyCapturedCountBox_.textContent =
+          g_browser.sourceTracker.getNumPassivelyCapturedEvents();
+    },
+
+    /**
+     * Depending on the value of the checkbox, enables or disables logging of
+     * actual bytes transferred.
+     */
+    onSetByteLogging_: function(byteLoggingCheckbox) {
+      if (byteLoggingCheckbox.checked) {
+        g_browser.setLogLevel(LogLevelType.LOG_ALL);
+      } else {
+        g_browser.setLogLevel(LogLevelType.LOG_ALL_BUT_BYTES);
+      }
+    }
+  };
+
+  return CaptureView;
+})();