Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 753963002: Revert of Modified MediaCodecBridge as per android API label 21. (Closed)

Created:
6 years ago by Thiemo Nagel
Modified:
6 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Modified MediaCodecBridge as per android API label 21. (patchset #6 id:100001 of https://codereview.chromium.org/687683002/) Reason for revert: Fails to compile on Win8 GN: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/686 Original issue's description: > Modified MediaCodecBridge as per android API label 21. > > The following methods are deprecated in API lavel 21 > 1) getCodecInfoAt(int) > 2) getCodecCount() > > As per API lavel 21 we should use getCodecInfos() instead of above > two API. > > BUG=None > > Committed: https://crrev.com/d064353cd04c9d8c1148c1d15ea5b3f88628e0e9 > Cr-Commit-Position: refs/heads/master@{#305404} TBR=qinmin@chromium.org,aurimas@chromium.org,boliu@chromium.org,jitendra.ks@samsung.com NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/6948e4a584d16ed02076146fda5e832daed95f0d Cr-Commit-Position: refs/heads/master@{#305405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -26 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 chunk +9 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Thiemo Nagel
Created Revert of Modified MediaCodecBridge as per android API label 21.
6 years ago (2014-11-24 09:30:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753963002/1
6 years ago (2014-11-24 09:31:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 09:32:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6948e4a584d16ed02076146fda5e832daed95f0d Cr-Commit-Position: refs/heads/master@{#305405}
6 years ago (2014-11-24 09:32:51 UTC) #4
boliu
FYI this revert was probably wrong. This is an android-only java file change. Can't possibly ...
6 years ago (2014-11-24 17:07:00 UTC) #5
Thiemo Nagel
Sorry for the overzealous revert. :(
6 years ago (2014-11-24 17:17:23 UTC) #6
boliu
On 2014/11/24 17:17:23, Thiemo Nagel wrote: > Sorry for the overzealous revert. :( Blame the ...
6 years ago (2014-11-24 17:18:33 UTC) #7
Thiemo Nagel
6 years ago (2014-11-24 17:49:38 UTC) #8
Message was sent while issue was closed.
> Blame the flaky compile? :)

No no, I'm to blame.  I should have looked more carefully.  Sorry again.

Powered by Google App Engine
This is Rietveld 408576698