Dismiss the multi window resizer when the user clicks outside of the resizer

ui/views/mouse_watcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/mouse_watcher.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/event_types.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 21 matching lines @@
   // ui::EventHandler implementation:
   virtual void OnMouseEvent(ui::MouseEvent* event) override {
     switch (event->type()) {
       case ui::ET_MOUSE_MOVED:
       case ui::ET_MOUSE_DRAGGED:
         HandleMouseEvent(MouseWatcherHost::MOUSE_MOVE);
         break;
       case ui::ET_MOUSE_EXITED:
         HandleMouseEvent(MouseWatcherHost::MOUSE_EXIT);
         break;
+      case ui::ET_MOUSE_PRESSED:
+        HandleMouseEvent(MouseWatcherHost::MOUSE_PRESS);
+        break;
       default:
         break;
     }
   }
 
  private:
   MouseWatcherHost* host() const { return mouse_watcher_->host_.get(); }
 
   // Called when a mouse event we're interested is seen.
   void HandleMouseEvent(MouseWatcherHost::MouseEventType event_type) {
     // It's safe to use last_mouse_location() here as this function is invoked
     // during event dispatching.
     if (!host()->Contains(EventMonitor::GetLastMouseLocation(), event_type)) {
       // Mouse moved outside the host's zone, start a timer to notify the

[sky, 2014/12/10 15:51:36]

Update comment.

[pkotwicz, 2014/12/10 18:38:27]

I have moved the comment into the else statement

       // listener.
-      if (!notify_listener_factory_.HasWeakPtrs()) {
+      if (event_type == MouseWatcherHost::MOUSE_PRESS) {
+        NotifyListener();

[sky, 2014/12/10 15:51:36]

Did you look at all listeners and make sure they really want to be notified on
mouse press immediately?

[pkotwicz, 2014/12/10 18:38:28]

I have not found any cases where notifying the listener on mouse press
immediately would cause harm.
It is slightly useful in the context of
chrome/browser/ui/views/autofill/tooltip_icon.cc

+      } else {
         base::MessageLoop::current()->PostDelayedTask(
-            FROM_HERE,
-            base::Bind(&Observer::NotifyListener,
-                       notify_listener_factory_.GetWeakPtr()),
+            FROM_HERE, base::Bind(&Observer::NotifyListener,
+                                  notify_listener_factory_.GetWeakPtr()),
             event_type == MouseWatcherHost::MOUSE_MOVE
                 ? base::TimeDelta::FromMilliseconds(kNotifyListenerTimeMs)
                 : mouse_watcher_->notify_on_exit_time_);
       }
     } else {
       // Mouse moved quickly out of the host and then into it again, so cancel
       // the timer.
       notify_listener_factory_.InvalidateWeakPtrs();
     }
   }
@@ skipping 38 matching lines @@
 void MouseWatcher::Stop() {
   observer_.reset(NULL);
 }
 
 void MouseWatcher::NotifyListener() {
   observer_.reset(NULL);
   listener_->MouseMovedOutOfHost();
 }
 
 }  // namespace views