MacViews: Move content::AcceleratedWidget to new component, ui/accelerated_widget_mac

ui/compositor/mac/accelerated_widget_mac.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_BROWSER_COMPOSITOR_ACCELERATED_WIDGET_HELPER_MAC_H_
-#define CONTENT_BROWSER_COMPOSITOR_ACCELERATED_WIDGET_HELPER_MAC_H_
+#ifndef UI_COMPOSITOR_MAC_ACCELERATED_WIDGET_HELPER_MAC_H_
+#define UI_COMPOSITOR_MAC_ACCELERATED_WIDGET_HELPER_MAC_H_
 
 #include <IOSurface/IOSurfaceAPI.h>
 #include <vector>
 
-#include "skia/ext/platform_canvas.h"
+#include "ui/compositor/compositor_export.h"
 #include "ui/events/latency_info.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/native_widget_types.h"
 
 #if defined(__OBJC__)
 #import <Cocoa/Cocoa.h>
 #import "base/mac/scoped_nsobject.h"
-#import "content/browser/compositor/io_surface_layer_mac.h"
 #include "ui/base/cocoa/remote_layer_api.h"

[ccameron, 2014/11/25 17:54:25]

I'd prefer for software_layer to live in ui/compositor.mac like the rest of the
stuff here rather than being moved to ui/base (does it need to be in ui/base for
a reason I didn't see)?

[tapted, 2014/11/25 23:53:55]

Done. There was an earlier objection to it being in ui/gl, but with the new
approach, the follow-up to this for in-process (i.e. http://crrev.com/756663004
) no longer needs it in ui/gl, so I agree ui/compositor/mac feels nicer.

Done (merged http://crrev.com/723903002 to this CL)

 #import "ui/base/cocoa/software_layer.h"
+#import "ui/compositor/mac/io_surface_layer_mac.h"
 #endif  // __OBJC__
 
+class SkCanvas;
+
 namespace cc {
 class SoftwareFrameData;
 }
 
+// TODO(tapted): Move this out of content namespace.

[ccameron, 2014/11/25 17:54:25]

I'd prefer to move this stuff to ui:: in this patch (it's not a big diff). I was
also wondering if this should be in gfx:: as-in gfx::AcceleratedWidget -- maybe
piman has a preference?

[tapted, 2014/11/25 23:53:55]

Done. (with ui:: for now so you can see how it looks [feels right to me])

 namespace content {
 
 class AcceleratedWidgetMac;
 
 // A class through which an AcceleratedWidget may be bound to draw the contents
 // of an NSView. An AcceleratedWidget may be bound to multiple different views
 // throughout its lifetime (one at a time, though).
 class AcceleratedWidgetMacNSView {
  public:
   virtual NSView* AcceleratedWidgetGetNSView() const = 0;
   virtual bool AcceleratedWidgetShouldIgnoreBackpressure() const = 0;
+  virtual bool AcceleratedWidgetNeedsGLFinishWorkaround() const = 0;
   virtual void AcceleratedWidgetSwapCompleted(
       const std::vector<ui::LatencyInfo>& latency_info) = 0;
   virtual void AcceleratedWidgetHitError() = 0;
 };
 
 #if defined(__OBJC__)
 
 // AcceleratedWidgetMac owns a tree of CALayers. The widget may be passed
 // to a ui::Compositor, which will cause, through its output surface, calls to
 // GotAcceleratedFrame and GotSoftwareFrame. The CALayers may be installed
 // in an NSView by setting the AcceleratedWidgetMacNSView for the helper.
-class AcceleratedWidgetMac : public IOSurfaceLayerClient {
+class COMPOSITOR_EXPORT AcceleratedWidgetMac : public IOSurfaceLayerClient {
  public:
   AcceleratedWidgetMac();
   virtual ~AcceleratedWidgetMac();
 
   gfx::AcceleratedWidget accelerated_widget() { return native_widget_; }
 
   void SetNSView(AcceleratedWidgetMacNSView* view);
   void ResetNSView();
 
   // Return true if the last frame swapped has a size in DIP of |dip_size|.
@@ skipping 16 matching lines @@
       gfx::Size pixel_size,
       float scale_factor,
       const base::Closure& drawn_callback);
 
   void GotSoftwareFrame(
       cc::SoftwareFrameData* frame_data, float scale_factor, SkCanvas* canvas);
 
 private:
   // IOSurfaceLayerClient implementation:
   bool IOSurfaceLayerShouldAckImmediately() const override;
+  bool IOSurfaceNeedsGLFinishWorkaround() const override;
   void IOSurfaceLayerDidDrawFrame() override;
   void IOSurfaceLayerHitError() override;
 
   void GotAcceleratedCAContextFrame(
       CAContextID ca_context_id, gfx::Size pixel_size, float scale_factor);
 
   void GotAcceleratedIOSurfaceFrame(
       IOSurfaceID io_surface_id, gfx::Size pixel_size, float scale_factor);
 
   void AcknowledgeAcceleratedFrame();
@@ skipping 39 matching lines @@
   base::Closure accelerated_frame_drawn_callback_;
 
   // The size in DIP of the last swap received from |compositor_|.
   gfx::Size last_swap_size_dip_;
 
   DISALLOW_COPY_AND_ASSIGN(AcceleratedWidgetMac);
 };
 
 #endif  // __OBJC__
 
+COMPOSITOR_EXPORT
 void AcceleratedWidgetMacGotAcceleratedFrame(
     gfx::AcceleratedWidget widget, uint64 surface_handle,
     const std::vector<ui::LatencyInfo>& latency_info,
     gfx::Size pixel_size, float scale_factor,
     const base::Closure& drawn_callback,
     bool* disable_throttling, int* renderer_id);
 
+COMPOSITOR_EXPORT
 void AcceleratedWidgetMacGotSoftwareFrame(
     gfx::AcceleratedWidget widget,
     cc::SoftwareFrameData* frame_data, float scale_factor, SkCanvas* canvas);
 
 }  // namespace content
 
-#endif  // CONTENT_BROWSER_COMPOSITOR_ACCELERATED_WIDGET_HELPER_MAC_H_
+#endif  // UI_COMPOSITOR_MAC_ACCELERATED_WIDGET_HELPER_MAC_H_