pkg/unittest/lib/html_config.dart - Issue 75393002: unittest: A unittest with 0 test cases should PASS, fixed incorrect unittest-suite-* messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/html_config.dart

Issue 75393002: unittest: A unittest with 0 test cases should PASS, fixed incorrect unittest-suite-* messages Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/lib/html_config.dart

diff --git a/pkg/unittest/lib/html_config.dart b/pkg/unittest/lib/html_config.dart

index 860ec4fa73d753831f59e4f840acffa17fb5b34f..03d774d3b6aa1f03b6000064e8e7ba836c92b344 100644

--- a/pkg/unittest/lib/html_config.dart

+++ b/pkg/unittest/lib/html_config.dart

@@ -166,7 +166,11 @@ class HtmlConfiguration extends SimpleConfiguration {

void onDone(bool success) {

_uninstallHandlers();

- window.postMessage('unittest-suite-done', '*');

+ if (success) {

+ window.postMessage('unittest-suite-success', '*');

+ } else {

+ window.postMessage('unittest-suite-fail', '*');

+ }

}

« no previous file with comments | « no previous file | pkg/unittest/lib/html_enhanced_config.dart » ('j') | tests/html/html.status » ('J')