Record type of content being downloaded.

Record type of content being downloaded.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95153

[benjhayden, 2011-08-01 18:53:03]

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:397: enum DownloadContent {
Do all compilers number enums from 0 counting upwards? I'm thinking of
histograms.xml.

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:417: static MimeTypeToDownloadContent
kMapMimeTypeToDownloadContent[] = {
Could you add exe, dmg, crx, and bzip?

exe: application/exe, application/x-exe, application/dos-exe, vms/exe,
application/x-winexe, application/msdos-windows, application/x-msdos-program

dmg: application/x-apple-diskimage

crx: application/x-chrome-extension

bzip: application/bzip2, application/x-bz2, application/x-bzip,
application/x-compressed, application/x-stuffit

[cbentzel, 2011-08-01 19:00:32]

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:397: enum DownloadContent {
On 2011/08/01 18:53:03, b s h wrote:
> Do all compilers number enums from 0 counting upwards? I'm thinking of
> histograms.xml.

Not guaranteed - thanks for the catch.

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:417: static MimeTypeToDownloadContent
kMapMimeTypeToDownloadContent[] = {
On 2011/08/01 18:53:03, b s h wrote:
> Could you add exe, dmg, crx, and bzip?
> 
> exe: application/exe, application/x-exe, application/dos-exe, vms/exe,
> application/x-winexe, application/msdos-windows, application/x-msdos-program
> 
> dmg: application/x-apple-diskimage
> 
> crx: application/x-chrome-extension
> 
> bzip: application/bzip2, application/x-bz2, application/x-bzip,
> application/x-compressed, application/x-stuffit

Will do. Hoping I don't need to move to binary search or map approach.

[cbentzel, 2011-08-01 21:06:18]

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:417: static MimeTypeToDownloadContent
kMapMimeTypeToDownloadContent[] = {
On 2011/08/01 18:53:03, b s h wrote:
> Could you add exe, dmg, crx, and bzip?
> 
> exe: application/exe, application/x-exe, application/dos-exe, vms/exe,
> application/x-winexe, application/msdos-windows, application/x-msdos-program

Do you know how frequently these happen? I mostly see octet-stream used instead.

> 
> dmg: application/x-apple-diskimage

Done.

> 
> crx: application/x-chrome-extension

Done.

> 
> bzip: application/bzip2, application/x-bz2, application/x-bzip,
> application/x-compressed, application/x-stuffit

I used x-bzip only, which is the standard mime type. Also mapped to ARCHIVE.

[benjhayden, 2011-08-01 21:48:11]

LGTM

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/7538007/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:417: static MimeTypeToDownloadContent
kMapMimeTypeToDownloadContent[] = {
On 2011/08/01 21:06:18, cbentzel wrote:
> On 2011/08/01 18:53:03, b s h wrote:
> > Could you add exe, dmg, crx, and bzip?
> > 
> > exe: application/exe, application/x-exe, application/dos-exe, vms/exe,
> > application/x-winexe, application/msdos-windows, application/x-msdos-program
> 
> Do you know how frequently these happen? I mostly see octet-stream used
instead.

No idea. I just copied it from some website. Don't sweat it too much.

> 
> > 
> > dmg: application/x-apple-diskimage
> 
> Done.
> 
> > 
> > crx: application/x-chrome-extension
> 
> Done.
> 
> > 
> > bzip: application/bzip2, application/x-bz2, application/x-bzip,
> > application/x-compressed, application/x-stuffit
> 
> I used x-bzip only, which is the standard mime type. Also mapped to ARCHIVE. 
> 

SGTM

[commit-bot: I haz the power, 2011-08-02 20:52:36]

Change committed as 95153