Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 753783003: Remove GrSurface::isSameAs (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -42 lines) Patch
M include/gpu/GrSurface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/GrSurfacePriv.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 1 2 4 chunks +26 lines, -20 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
bsalomon
Cleanup after the diamond change.
6 years ago (2014-11-25 15:29:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753783003/40001
6 years ago (2014-11-25 15:30:10 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-25 15:30:11 UTC) #5
robertphillips
lgtm + nit https://codereview.chromium.org/753783003/diff/40001/tests/GrSurfaceTest.cpp File tests/GrSurfaceTest.cpp (right): https://codereview.chromium.org/753783003/diff/40001/tests/GrSurfaceTest.cpp#newcode61 tests/GrSurfaceTest.cpp:61: REPORTER_ASSERT(reporter, static_cast<GrSurface*>(texRT2->asRenderTarget()) == extra space ?
6 years ago (2014-11-25 15:34:59 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-25 15:41:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a2c2323005fb22e564426f4ed86adaa6d213aba1

Powered by Google App Engine
This is Rietveld 408576698