Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 753743005: Explicitly clear out the IC-data register in ExecuteMatch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: x64 fix and mips mov Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc
index 713282a339076628770ab103785589c13e68705f..9101614bb185d22c602ba6722fab64a358b28ea4 100644
--- a/runtime/vm/intrinsifier_ia32.cc
+++ b/runtime/vm/intrinsifier_ia32.cc
@@ -2060,7 +2060,7 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
// Incoming registers:
// EAX: Function. (Will be loaded with the specialized matcher function.)
- // ECX: IC-Data. (Will be preserved.)
+ // ECX: Unknown. (Must be GC safe on tail call.)
// EDX: Arguments descriptor. (Will be preserved.)
// Load the specialized function pointer into EAX. Leverage the fact the
@@ -2076,6 +2076,7 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
// in EAX, the argument descriptor in EDX, and IC-Data in ECX.
static const intptr_t arg_count = RegExpMacroAssembler::kParamCount;
__ LoadObject(EDX, Array::Handle(ArgumentsDescriptor::New(arg_count)));
+ __ xorl(ECX, ECX);
// Tail-call the function.
__ movl(EDI, FieldAddress(EAX, Function::instructions_offset()));
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698