Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 753743003: Remove remaining implicit scoped_ptr<T> to T* conversions in win8 (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove remaining implicit scoped_ptr<T> to T* conversions in win8 GetArgumentsFromShortcut() introduced a new implicit conversion since the last time the clang tool was run. The other fix in MetroViewerProcessHost simply changes the TaskRunner pointer to be passed as a scoped_refptr<T>, since it takes a ref to the TaskRunner. BUG=110610 Committed: https://crrev.com/90590193a9c5b5bc674f1c7680761306ed42c1f1 Cr-Commit-Position: refs/heads/master@{#305511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M win8/metro_driver/winrt_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years ago (2014-11-24 18:12:59 UTC) #2
grt (UTC plus 2)
lgtm
6 years ago (2014-11-24 21:41:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753743003/1
6 years ago (2014-11-24 21:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 22:59:03 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-24 22:59:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90590193a9c5b5bc674f1c7680761306ed42c1f1
Cr-Commit-Position: refs/heads/master@{#305511}

Powered by Google App Engine
This is Rietveld 408576698