Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 753683004: Revert of Supervised user SafeSites: Expose & use API key from src-internal (Closed)

Created:
6 years ago by Thiemo Nagel
Modified:
6 years ago
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Supervised user SafeSites: Expose & use API key from src-internal (patchset #5 id:80001 of https://codereview.chromium.org/690423003/) Reason for revert: Build breakage on Mac: https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/14318/steps/steps/logs/stdio Original issue's description: > Supervised user SafeSites: Expose & use API key from src-internal > > Key was added to src-internal in https://chromereviews.googleplex.com/113767014/ > > BUG=417722 > > Committed: https://crrev.com/2ee5f146d57d07bbad3804715e06590b850711f9 > Cr-Commit-Position: refs/heads/master@{#305412} TBR=rogerta@chromium.org,bauerb@chromium.org,treib@chromium.org NOTREECHECKS=true NOTRY=true BUG=417722 Committed: https://crrev.com/13c88c66f60e6364478a411e8ccf0bfd689f0a96 Cr-Commit-Position: refs/heads/master@{#305413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M google_apis/google_api_keys.h View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/google_api_keys.cc View 5 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Thiemo Nagel
Created Revert of Supervised user SafeSites: Expose & use API key from src-internal
6 years ago (2014-11-24 11:32:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753683004/1
6 years ago (2014-11-24 11:32:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 11:33:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13c88c66f60e6364478a411e8ccf0bfd689f0a96 Cr-Commit-Position: refs/heads/master@{#305413}
6 years ago (2014-11-24 11:34:00 UTC) #4
Marc Treib
6 years ago (2014-11-24 12:33:56 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/756593002/ by treib@chromium.org.

The reason for reverting is: Relanding because the original reason for reverting
looks like a flake rather than an issue with the CL..

Powered by Google App Engine
This is Rietveld 408576698