Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: sky/compositor/layer_host.cc

Issue 753643002: Enable the Sky compositor again (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Moar comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/compositor/layer_host.h ('k') | sky/compositor/surface_holder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/compositor/layer_host.cc
diff --git a/sky/compositor/layer_host.cc b/sky/compositor/layer_host.cc
index a1991770c3b4a827fc12f5835b09c1ecaf06d38c..9a635e6d4a211a3c1e06396ca47a1899f31509e6 100644
--- a/sky/compositor/layer_host.cc
+++ b/sky/compositor/layer_host.cc
@@ -15,6 +15,7 @@ namespace sky {
LayerHost::LayerHost(LayerHostClient* client)
: client_(client),
+ state_(kIdle),
surface_holder_(this, client->GetShell()),
gl_context_(mojo::GLContext::Create(client->GetShell())),
ganesh_context_(gl_context_),
@@ -29,6 +30,7 @@ LayerHost::~LayerHost() {
void LayerHost::SetNeedsAnimate() {
scheduler_.SetNeedsFrame();
+ state_ = kWaitingForBeginFrame;
}
void LayerHost::SetRootLayer(scoped_refptr<Layer> layer) {
@@ -39,6 +41,9 @@ void LayerHost::SetRootLayer(scoped_refptr<Layer> layer) {
void LayerHost::OnSurfaceIdAvailable(mojo::SurfaceIdPtr surface_id) {
client_->OnSurfaceIdAvailable(surface_id.Pass());
+
+ if (state_ == kWaitingForSurfaceToUploadFrame)
+ Upload(root_layer_.get());
}
void LayerHost::ReturnResources(
@@ -48,6 +53,8 @@ void LayerHost::ReturnResources(
void LayerHost::BeginFrame(base::TimeTicks frame_time,
base::TimeTicks deadline) {
+ DCHECK_EQ(state_, kWaitingForBeginFrame);
+ state_ = kProducingFrame;
client_->BeginFrame(frame_time);
{
@@ -57,9 +64,30 @@ void LayerHost::BeginFrame(base::TimeTicks frame_time,
}
Upload(root_layer_.get());
+
+ if (state_ == kProducingFrame)
+ state_ = kIdle;
}
void LayerHost::Upload(Layer* layer) {
+ if (!surface_holder_.IsReadyForFrame()) {
+ if (state_ == kProducingFrame) {
+ // Currently we use a timer to drive the BeginFrame cycle, which means we
+ // can produce frames before the surfaces service is ready to receive
+ // frames from us. In that situation, we wait for surfaces before
+ // uploading the frame. The upload will actually happen when the surface
+ // id is available (i.e., in OnSurfaceIdAvailable). If SetNeedsAnimate is
+ // called before then, we'll go back into the kWaitingForBeginFrame state
+ // and defer to the timer again.
+ //
+ // We can avoid this complexity if we use feedback from the surfaces
+ // service to drive the BeginFrame cycle. In that approach, we wouldn't
+ // get here before we've attached to a surface.
+ state_ = kWaitingForSurfaceToUploadFrame;
+ }
+ return;
+ }
+
gfx::Size size = layer->size();
surface_holder_.SetSize(size);
« no previous file with comments | « sky/compositor/layer_host.h ('k') | sky/compositor/surface_holder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698