Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 753633002: Simplfy DEPS: always pull all deps, remove unused barelinux platform. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, borenet, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Simplfy DEPS: always pull all deps, remove unused barelinux platform. Left some notes about where we might further clean up. BUG=skia: Committed: https://skia.googlesource.com/skia/+/76b3ac9eff95e385e59ff2706b11facd695234fd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -356 lines) Patch
M DEPS View 1 chunk +16 lines, -39 lines 2 comments Download
D platform_tools/barelinux/bin/arm64_download View 1 chunk +0 lines, -150 lines 0 comments Download
D platform_tools/barelinux/bin/arm64_make View 1 chunk +0 lines, -55 lines 0 comments Download
D platform_tools/barelinux/bin/barelinux_make View 1 chunk +0 lines, -83 lines 0 comments Download
D platform_tools/barelinux/bin/download_deps View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
6 years, 1 month ago (2014-11-21 19:05:16 UTC) #2
borenet
LGTM, +Derek to see if we can consolidate libjpeg. https://codereview.chromium.org/753633002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/753633002/diff/1/DEPS#newcode10 DEPS:10: ...
6 years, 1 month ago (2014-11-21 19:24:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753633002/1
6 years, 1 month ago (2014-11-21 19:28:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/76b3ac9eff95e385e59ff2706b11facd695234fd
6 years, 1 month ago (2014-11-21 19:41:38 UTC) #7
djsollen
6 years, 1 month ago (2014-11-21 19:45:53 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/753633002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/753633002/diff/1/DEPS#newcode10
DEPS:10: #   - can use use our existing t_p/e/libjpeg instead of pulling it for
Android?
On 2014/11/21 19:24:10, borenet wrote:
> That's a question for Derek.

We need the android specific jpeg for now as it is a fork of libjpeg that only
android uses so we want to make sure we test the decoder that they are shipping
with.

Powered by Google App Engine
This is Rietveld 408576698