Issue 75363002: Set focus to the "OK" button when editing a supervised user profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75363002: Set focus to the "OK" button when editing a supervised user profile (Closed)

Created:
7 years, 1 month ago by Pam (message me for reviews)

Modified:
7 years, 1 month ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, dbeam+watch-options_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Set focus to the "OK" button when editing a supervised user profile Since a supervised user can't edit their name, trying to set the focus there resulted in it ending up on the first element in the tab order. On Mac and Linux, that was the "Cancel" button, rather than "OK", because the button order is reversed to fit those platforms' conventions. Set focus more deliberately. BUG=315532 TEST=new browser_test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235754

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/manage_profile_overlay.js	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/options/manage_profile_browsertest.js	View		2 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Focus issues are almost as much fun as race conditions! Yay!

7 years, 1 month ago (2013-11-18 15:31:07 UTC) #1

Bernhard Bauer

LGTM Maybe you can get a race condition that surfaces as a focus issue?

7 years, 1 month ago (2013-11-18 15:33:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/75363002/1

7 years, 1 month ago (2013-11-18 15:40:00 UTC) #3

Message was sent while issue was closed.

Change committed as 235754

Expand Messages | Collapse Messages