base/prefs/pref_value_store_unittest.cc - Issue 753603002: Change preference APIs to take std::string instead of const char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_value_store_unittest.cc

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_value_store_unittest.cc

diff --git a/base/prefs/pref_value_store_unittest.cc b/base/prefs/pref_value_store_unittest.cc

index 3afe9dcefd19b47adbd934d55c2a02c5b7500154..9194b22ad7eca738fc6f29fb27faab34f748d317 100644

--- a/base/prefs/pref_value_store_unittest.cc

+++ b/base/prefs/pref_value_store_unittest.cc

@@ -237,7 +237,7 @@ class PrefValueStoreTest : public testing::Test {

default_pref::kDefaultValue);

}

- void ExpectValueChangeNotifications(const char* name) {

+ void ExpectValueChangeNotifications(const std::string& name) {

EXPECT_CALL(pref_notifier_, OnPreferenceChanged(name));

EXPECT_CALL(*sync_associator_, ProcessPrefChange(name));

}

« no previous file with comments | « base/prefs/pref_value_store.cc ('k') | base/prefs/scoped_user_pref_update.h » ('j') | no next file with comments »