base/prefs/pref_notifier_impl.h - Issue 753603002: Change preference APIs to take std::string instead of const char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_notifier_impl.h

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_notifier_impl.h

diff --git a/base/prefs/pref_notifier_impl.h b/base/prefs/pref_notifier_impl.h

index 3f4c254c416a6ec803028f9fe4304f6dbbb671c3..cfd46ff4211ff2ef9196723d83e549e5ececeebe 100644

--- a/base/prefs/pref_notifier_impl.h

+++ b/base/prefs/pref_notifier_impl.h

@@ -29,8 +29,8 @@ class BASE_PREFS_EXPORT PrefNotifierImpl

// If the pref at the given path changes, we call the observer's

// OnPreferenceChanged method.

- void AddPrefObserver(const char* path, PrefObserver* observer);

- void RemovePrefObserver(const char* path, PrefObserver* observer);

+ void AddPrefObserver(const std::string& path, PrefObserver* observer);

+ void RemovePrefObserver(const std::string& path, PrefObserver* observer);

// We run the callback once, when initialization completes. The bool

// parameter will be set to true for successful initialization,

« no previous file with comments | « base/prefs/pref_member_unittest.cc ('k') | base/prefs/pref_notifier_impl.cc » ('j') | no next file with comments »