Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: base/prefs/pref_registry_simple.cc

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/prefs/pref_registry_simple.h ('k') | base/prefs/pref_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_registry_simple.h" 5 #include "base/prefs/pref_registry_simple.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 10
11 PrefRegistrySimple::PrefRegistrySimple() { 11 PrefRegistrySimple::PrefRegistrySimple() {
12 } 12 }
13 13
14 PrefRegistrySimple::~PrefRegistrySimple() { 14 PrefRegistrySimple::~PrefRegistrySimple() {
15 } 15 }
16 16
17 void PrefRegistrySimple::RegisterBooleanPref(const char* path, 17 void PrefRegistrySimple::RegisterBooleanPref(const std::string& path,
18 bool default_value) { 18 bool default_value) {
19 RegisterPreference(path, new base::FundamentalValue(default_value)); 19 RegisterPreference(path, new base::FundamentalValue(default_value));
20 } 20 }
21 21
22 void PrefRegistrySimple::RegisterIntegerPref(const char* path, 22 void PrefRegistrySimple::RegisterIntegerPref(const std::string& path,
23 int default_value) { 23 int default_value) {
24 RegisterPreference(path, new base::FundamentalValue(default_value)); 24 RegisterPreference(path, new base::FundamentalValue(default_value));
25 } 25 }
26 26
27 void PrefRegistrySimple::RegisterDoublePref(const char* path, 27 void PrefRegistrySimple::RegisterDoublePref(const std::string& path,
28 double default_value) { 28 double default_value) {
29 RegisterPreference(path, new base::FundamentalValue(default_value)); 29 RegisterPreference(path, new base::FundamentalValue(default_value));
30 } 30 }
31 31
32 void PrefRegistrySimple::RegisterStringPref(const char* path, 32 void PrefRegistrySimple::RegisterStringPref(const std::string& path,
33 const std::string& default_value) { 33 const std::string& default_value) {
34 RegisterPreference(path, new base::StringValue(default_value)); 34 RegisterPreference(path, new base::StringValue(default_value));
35 } 35 }
36 36
37 void PrefRegistrySimple::RegisterFilePathPref( 37 void PrefRegistrySimple::RegisterFilePathPref(
38 const char* path, 38 const std::string& path,
39 const base::FilePath& default_value) { 39 const base::FilePath& default_value) {
40 RegisterPreference(path, new base::StringValue(default_value.value())); 40 RegisterPreference(path, new base::StringValue(default_value.value()));
41 } 41 }
42 42
43 void PrefRegistrySimple::RegisterListPref(const char* path) { 43 void PrefRegistrySimple::RegisterListPref(const std::string& path) {
44 RegisterPreference(path, new base::ListValue()); 44 RegisterPreference(path, new base::ListValue());
45 } 45 }
46 46
47 void PrefRegistrySimple::RegisterListPref(const char* path, 47 void PrefRegistrySimple::RegisterListPref(const std::string& path,
48 base::ListValue* default_value) { 48 base::ListValue* default_value) {
49 RegisterPreference(path, default_value); 49 RegisterPreference(path, default_value);
50 } 50 }
51 51
52 void PrefRegistrySimple::RegisterDictionaryPref(const char* path) { 52 void PrefRegistrySimple::RegisterDictionaryPref(const std::string& path) {
53 RegisterPreference(path, new base::DictionaryValue()); 53 RegisterPreference(path, new base::DictionaryValue());
54 } 54 }
55 55
56 void PrefRegistrySimple::RegisterDictionaryPref( 56 void PrefRegistrySimple::RegisterDictionaryPref(
57 const char* path, 57 const std::string& path,
58 base::DictionaryValue* default_value) { 58 base::DictionaryValue* default_value) {
59 RegisterPreference(path, default_value); 59 RegisterPreference(path, default_value);
60 } 60 }
61 61
62 void PrefRegistrySimple::RegisterInt64Pref(const char* path, 62 void PrefRegistrySimple::RegisterInt64Pref(const std::string& path,
63 int64 default_value) { 63 int64 default_value) {
64 RegisterPreference( 64 RegisterPreference(
65 path, new base::StringValue(base::Int64ToString(default_value))); 65 path, new base::StringValue(base::Int64ToString(default_value)));
66 } 66 }
OLDNEW
« no previous file with comments | « base/prefs/pref_registry_simple.h ('k') | base/prefs/pref_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698