Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: base/prefs/pref_change_registrar_unittest.cc

Issue 753603002: Change preference APIs to take std::string instead of const char*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed all calls to c_str() in prefs. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/prefs/pref_change_registrar.cc ('k') | base/prefs/pref_member.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/prefs/pref_change_registrar.h" 7 #include "base/prefs/pref_change_registrar.h"
8 #include "base/prefs/pref_observer.h" 8 #include "base/prefs/pref_observer.h"
9 #include "base/prefs/pref_registry_simple.h" 9 #include "base/prefs/pref_registry_simple.h"
10 #include "base/prefs/testing_pref_service.h" 10 #include "base/prefs/testing_pref_service.h"
11 #include "testing/gmock/include/gmock/gmock.h" 11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 using testing::Mock; 14 using testing::Mock;
15 using testing::Eq; 15 using testing::Eq;
16 16
17 namespace base { 17 namespace base {
18 namespace { 18 namespace {
19 19
20 const char kHomePage[] = "homepage"; 20 const char kHomePage[] = "homepage";
21 const char kHomePageIsNewTabPage[] = "homepage_is_newtabpage"; 21 const char kHomePageIsNewTabPage[] = "homepage_is_newtabpage";
22 const char kApplicationLocale[] = "intl.app_locale"; 22 const char kApplicationLocale[] = "intl.app_locale";
23 23
24 // A mock provider that allows us to capture pref observer changes. 24 // A mock provider that allows us to capture pref observer changes.
25 class MockPrefService : public TestingPrefServiceSimple { 25 class MockPrefService : public TestingPrefServiceSimple {
26 public: 26 public:
27 MockPrefService() {} 27 MockPrefService() {}
28 virtual ~MockPrefService() {} 28 virtual ~MockPrefService() {}
29 29
30 MOCK_METHOD2(AddPrefObserver, 30 MOCK_METHOD2(AddPrefObserver, void(const std::string&, PrefObserver*));
31 void(const char*, PrefObserver*)); 31 MOCK_METHOD2(RemovePrefObserver, void(const std::string&, PrefObserver*));
32 MOCK_METHOD2(RemovePrefObserver,
33 void(const char*, PrefObserver*));
34 }; 32 };
35 33
36 } // namespace 34 } // namespace
37 35
38 class PrefChangeRegistrarTest : public testing::Test { 36 class PrefChangeRegistrarTest : public testing::Test {
39 public: 37 public:
40 PrefChangeRegistrarTest() {} 38 PrefChangeRegistrarTest() {}
41 virtual ~PrefChangeRegistrarTest() {} 39 virtual ~PrefChangeRegistrarTest() {}
42 40
43 protected: 41 protected:
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 pref_service_->SetUserPref(kHomePageIsNewTabPage, 189 pref_service_->SetUserPref(kHomePageIsNewTabPage,
192 new FundamentalValue(true)); 190 new FundamentalValue(true));
193 Mock::VerifyAndClearExpectations(this); 191 Mock::VerifyAndClearExpectations(this);
194 192
195 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0); 193 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0);
196 pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8")); 194 pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8"));
197 Mock::VerifyAndClearExpectations(this); 195 Mock::VerifyAndClearExpectations(this);
198 } 196 }
199 197
200 } // namespace base 198 } // namespace base
OLDNEW
« no previous file with comments | « base/prefs/pref_change_registrar.cc ('k') | base/prefs/pref_member.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698