Change preference APIs to take std::string instead of const char*.

base/prefs/pref_change_registrar.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_change_registrar.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 
 PrefChangeRegistrar::PrefChangeRegistrar() : service_(NULL) {}
 
 PrefChangeRegistrar::~PrefChangeRegistrar() {
   // If you see an invalid memory access in this destructor, this
   // PrefChangeRegistrar might be subscribed to an OffTheRecordProfileImpl that
   // has been destroyed. This should not happen any more but be warned.
   // Feel free to contact battre@chromium.org in case this happens.
   RemoveAll();
 }
 
 void PrefChangeRegistrar::Init(PrefService* service) {
   DCHECK(IsEmpty() || service_ == service);
   service_ = service;
 }
 
-void PrefChangeRegistrar::Add(const char* path,
+void PrefChangeRegistrar::Add(const std::string& path,
                               const base::Closure& obs) {
   Add(path, base::Bind(&PrefChangeRegistrar::InvokeUnnamedCallback, obs));
 }
 
-void PrefChangeRegistrar::Add(const char* path,
+void PrefChangeRegistrar::Add(const std::string& path,
                               const NamedChangeCallback& obs) {
   if (!service_) {
     NOTREACHED();
     return;
   }
   DCHECK(!IsObserved(path)) << "Already had this pref registered.";
 
   service_->AddPrefObserver(path, this);
   observers_[path] = obs;
 }
 
-void PrefChangeRegistrar::Remove(const char* path) {
+void PrefChangeRegistrar::Remove(const std::string& path) {
   DCHECK(IsObserved(path));
 
   observers_.erase(path);
   service_->RemovePrefObserver(path, this);
 }
 
 void PrefChangeRegistrar::RemoveAll() {
   for (ObserverMap::const_iterator it = observers_.begin();
        it != observers_.end(); ++it) {
     service_->RemovePrefObserver(it->first.c_str(), this);

[gab, 2014/12/01 21:13:01]

To get the full benefit, callers of those APIs should also be updated, any plans
here? (it's relatively easy to search for ._str() in base/prefs and fix those
(which may already help a bunch), but doing it at scale is harder).

[Georges Khalil, 2014/12/02 17:57:00]

Done.

   }
 
   observers_.clear();
 }
 
 bool PrefChangeRegistrar::IsEmpty() const {
   return observers_.empty();
 }
 
 bool PrefChangeRegistrar::IsObserved(const std::string& pref) {
@@ skipping 22 matching lines @@
   callback.Run();
 }
 
 PrefService* PrefChangeRegistrar::prefs() {
   return service_;
 }
 
 const PrefService* PrefChangeRegistrar::prefs() const {
   return service_;
 }