Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 753563003: exc_server_variants: use DISALLOW_COPY_AND_ASSIGN (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

exc_server_variants: use DISALLOW_COPY_AND_ASSIGN. TEST=util_test ExcServerVariants.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e4551e709ce7f83913d42eeb80cee0379a10bc7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M util/mach/exc_server_variants.h View 6 chunks +11 lines, -0 lines 0 comments Download
M util/mach/exc_server_variants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-11-21 16:55:51 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-11-21 17:47:39 UTC) #3
Mark Mentovai
6 years ago (2014-11-21 19:29:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4551e709ce7f83913d42eeb80cee0379a10bc7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698