src/debug.h - Issue 753553002: Phantom references support internal fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.h

Issue 753553002: Phantom references support internal fields (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Queue up phantom callbacks during GC to dispatch later Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug.h

diff --git a/src/debug.h b/src/debug.h

index 26d6ea589527744fb15b28fa87017be7bc560e15..edb833daaaa0dcd8c2029647477dcb2933c68d52 100644

--- a/src/debug.h

+++ b/src/debug.h

@@ -447,8 +447,7 @@ class Debug {

Object** restarter_frame_function_pointer);

// Passed to MakeWeak.

- static void HandleWeakDebugInfo(

- const v8::WeakCallbackData<v8::Value, void>& data);

+ static void HandlePhantomDebugInfo(const v8::PhantomCallbackData<void>& data);

// Threading support.

char* ArchiveDebug(char* to);