Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: src/api.cc

Issue 753553002: Phantom references support internal fields (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Delete allocated objects in test to make memory sanitizer happy Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8.h ('K') | « include/v8.h ('k') | src/debug.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index d094dbd55c4cf9f20e4ee3caf48bf846333152d5..8ae7b858c3e78f979f8bf860536396e79731db3b 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -402,12 +402,24 @@ i::Object** V8::CopyPersistent(i::Object** obj) {
}
-void V8::MakeWeak(i::Object** object, void* parameters,
- WeakCallback weak_callback, V8::WeakHandleType weak_type) {
- i::GlobalHandles::PhantomState phantom;
- phantom = weak_type == V8::PhantomHandle ? i::GlobalHandles::Phantom
- : i::GlobalHandles::Nonphantom;
- i::GlobalHandles::MakeWeak(object, parameters, weak_callback, phantom);
+void V8::MakeWeak(i::Object** object, void* parameter,
+ WeakCallback weak_callback) {
+ i::GlobalHandles::MakeWeak(object, parameter, weak_callback);
+}
+
+
+void V8::MakePhantom(i::Object** object, void* parameter,
+ PhantomCallbackData<void>::Callback weak_callback) {
+ i::GlobalHandles::MakePhantom(object, parameter, weak_callback);
+}
+
+
+void V8::MakePhantom(
+ i::Object** object,
+ InternalFieldsCallbackData<void, void>::Callback weak_callback,
+ int internal_field_index1, int internal_field_index2) {
+ i::GlobalHandles::MakePhantom(object, weak_callback, internal_field_index1,
+ internal_field_index2);
}
« include/v8.h ('K') | « include/v8.h ('k') | src/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698