pylint: upgrade to 1.4.0

pylint: upgrade to 1.4.0

This is largely a bugfix release, so should be much easier to transition.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293355

[vapier, 2014-12-03 02:47:43]

vapier@chromium.org changed reviewers:
+ agable@chromium.org, chrisha@chromium.org, kbr@chromium.org,
maruel@chromium.org, yyanagisawa@google.com

[M-A Ruel, 2014-12-03 02:52:10]

lgtm

[Yoshisato Yanagisawa, 2014-12-03 03:15:07]

lgtm

[vapier, 2014-12-03 06:24:19]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-12-03 06:24:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753543006/1

[commit-bot: I haz the power, 2014-12-03 06:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-03 06:27:17]

Presubmit check for 753543006-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 127.8s to calculate.

[vapier, 2014-12-03 06:57:00]

no idea why, but that output is truncated and omits the important line:
error: pathspec 'refs/remotes/trunk' did not match any file(s) known to git.

so much for trying to use git on this repo :/

[vapier, 2014-12-03 07:15:38]

looks like the unittests fail for svn too.  and they fail in git w/out my CL. 
no idea what's going on.

[vapier, 2014-12-04 23:55:24]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-12-04 23:56:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753543006/1

[commit-bot: I haz the power, 2014-12-04 23:58:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-04 23:58:30]

Presubmit check for 753543006-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
dcommit
TESTING: post-cl-dcommit hook executed
FAILURE: post-cl-dcommit hook executed


Presubmit checks took 104.7s to calculate.

[vapier, 2014-12-11 16:25:36]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-12-11 16:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753543006/1

[commit-bot: I haz the power, 2014-12-11 16:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 16:28:55]

Presubmit check for 753543006-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (68.86s) failed
Ffatal: reference is not a tree: d4092c554da28595986dfd77f8d1b47c009a5513
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeGit, but move the main project using directly
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1628, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
d4092c554da28595986dfd77f8d1b47c009a5513 returned non-zero exit status 128 in
/tmp/trialNWyUiw/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1654, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialNWyUiw/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialNWyUiw/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1600, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 68.521s

FAILED (failures=1, errors=2)


Presubmit checks took 132.8s to calculate.

[M-A Ruel, 2014-12-11 16:31:56]

On 2014/12/11 16:28:55, I haz the power (commit-bot) wrote:
> ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)

This was added with https://codereview.chromium.org/743083002/.

[M-A Ruel, 2014-12-11 18:33:14]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-12-11 18:34:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753543006/1

[commit-bot: I haz the power, 2014-12-11 18:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 18:36:32]

Presubmit check for 753543006-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_test.py (0.54s) failed
........
foo (ERROR)
----------------------------------------
[0:00:00] Started.
----------------------------------------
.
foo (ERROR)
----------------------------------------
[0:00:00] Started.
----------------------------------------
.....F.........
======================================================================
FAIL: testRecursedepsOverride (__main__.GclientTest)
Verifies gclient respects the |recursedeps| var syntax.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_test.py", line 721, in testRecursedepsOverride
    self._get_processed())
AssertionError: Lists differ: ['svn://example.com/foo', 'svn... !=
['svn://example.com/foo', 'svn...

First differing element 1:
svn://example.com/bar
svn://example.com/tar

  ['svn://example.com/foo',
+  'svn://example.com/tar',
   'svn://example.com/bar',
-  'svn://example.com/tar',
   'svn://example.com/foo/bar',
   'svn://example.com/foo/bar/baz',
   'svn://example.com/foo/bar/baz/fizz']

----------------------------------------------------------------------
Ran 24 tests in 0.214s

FAILED (failures=1)


Presubmit checks took 108.8s to calculate.

[vapier, 2014-12-11 21:28:28]

The CQ bit was checked by vapier@chromium.org

[dcheng, 2014-12-12 02:23:21]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org, pdr@chromium.org, rtoy@chromium.org,
yyanagisawa@chromium.org

[dcheng, 2014-12-12 02:23:22]

I'm pretty sure this broke the blink layout test bots. They are all failing in
the webkit_python_tests stage.

[dcheng, 2014-12-12 02:37:30]

I fixed the blink test in https://codereview.chromium.org/795353004, since it
turns out it was pretty straightforward. Sorry for the noise.

[vapier, 2014-12-12 03:01:32]

thanks for that!  i wonder if there's a way we could make unittest a bit more
stable.  it seems to break every time pylint changes :/.  maybe match specific
sub-parts of the message that we care about.

[Dirk Pranke, 2014-12-12 03:37:06]

On 2014/12/12 03:01:32, vapier wrote:
> thanks for that!  i wonder if there's a way we could make unittest a bit more
> stable.  it seems to break every time pylint changes :/.  maybe match specific
> sub-parts of the message that we care about.

Part of the problem is that the test is testing the entire contents of the
pylint warnings, and this roll added a new warning.

Frankly, at this point, I'm not sure that the webkitpy tests are adding any real
value. We should probably at least change them to stub out the call to pylint so
that we're just testing the webkitpy code.