Change how SkDebugf is sent to stdout on Android.

Change how SkDebugf is sent to stdout on Android.

Previously, a function was called using dlsym in skia_launcher.

Add a static initializer that changes the setting, and include that for
the tools we automate for testing.

Also only do va_copy if we actually use it.

BUG=skia:2454
Committed: https://skia.googlesource.com/skia/+/6cfce1b7b4ad546b02823a1a0bbbda2c17b688f5

[djsollen, 2014-11-21 19:00:09]

djsollen@google.com changed reviewers:
+ djsollen@google.com

[djsollen, 2014-11-21 19:00:10]

so your saying this works in the main skia repo, but not for the framework
build?

https://codereview.chromium.org/753543003/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/753543003/diff/1/gyp/bench.gyp#newcode23
gyp/bench.gyp:23: 'android_output.gyp:android_output',
just put this in apptype_console.gypi

[scroggo, 2014-11-21 19:14:20]

On 2014/11/21 19:00:10, djsollen wrote:
> so your saying this works in the main skia repo, but not for the framework
> build?

That is correct.

https://codereview.chromium.org/753543003/diff/1/gyp/bench.gyp
File gyp/bench.gyp (right):

https://codereview.chromium.org/753543003/diff/1/gyp/bench.gyp#newcode23
gyp/bench.gyp:23: 'android_output.gyp:android_output',
On 2014/11/21 19:00:10, djsollen wrote:
> just put this in apptype_console.gypi

Done.

[djsollen, 2014-12-09 18:55:41]

I doubt this would work either, but it is worth a try.

https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
File tools/AndroidSkDebugToStdOut.cpp (right):

https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
tools/AndroidSkDebugToStdOut.cpp:20: static SendToStdOut gSendToStdOut;
try...

bool sendToStdOut() {
  gSkDebugToStdOut = true;
}

static bool gSendToStdOut = sendToStdOut();

[scroggo, 2014-12-10 17:03:44]

On 2014/12/09 18:55:41, djsollen wrote:
> I doubt this would work either, but it is worth a try.
> 
>
https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
> File tools/AndroidSkDebugToStdOut.cpp (right):
> 
>
https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
> tools/AndroidSkDebugToStdOut.cpp:20: static SendToStdOut gSendToStdOut;
> try...
> 
> bool sendToStdOut() {
>   gSkDebugToStdOut = true;
> }
> 
> static bool gSendToStdOut = sendToStdOut();

As we speculated yesterday, the problem is that SK_BUILD_FOR_ANDROID was not
defined in the framework build (since it's defined in SkUserConfig rather than
in the makefile). Adding #include SkTypes.h fixes the problem. The more I read
about using static initializers for their side effects, the more they scare me,
but we are already depending on their behavior for SkImageDecoder anyway...

I have another alternative in https://codereview.chromium.org/790203002/
(DIFFERENT CL!), which piggybacks on SkGraphics::Init().

[scroggo, 2014-12-10 17:11:30]

On 2014/12/10 17:03:44, scroggo wrote:
> On 2014/12/09 18:55:41, djsollen wrote:
> > I doubt this would work either, but it is worth a try.
> > 
> >
>
https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
> > File tools/AndroidSkDebugToStdOut.cpp (right):
> > 
> >
>
https://codereview.chromium.org/753543003/diff/20001/tools/AndroidSkDebugToSt...
> > tools/AndroidSkDebugToStdOut.cpp:20: static SendToStdOut gSendToStdOut;
> > try...
> > 
> > bool sendToStdOut() {
> >   gSkDebugToStdOut = true;
> > }
> > 
> > static bool gSendToStdOut = sendToStdOut();
> 
> As we speculated yesterday, the problem is that SK_BUILD_FOR_ANDROID was not
> defined in the framework build (since it's defined in SkUserConfig rather than
> in the makefile). Adding #include SkTypes.h fixes the problem. The more I read
> about using static initializers for their side effects, the more they scare
me,
> but we are already depending on their behavior for SkImageDecoder anyway...
> 
> I have another alternative in https://codereview.chromium.org/790203002/
> (DIFFERENT CL!), which piggybacks on SkGraphics::Init().

And another approach that I've considered, but not tried: add flag to
SkCommonFlags for it. Not
sure where to handle it, but it seems like that would define it where we want
it.

[djsollen, 2014-12-10 17:44:11]

I think this is cleaner and more general purpose than the skia_launcher hack so
this lgtm.

[djsollen, 2014-12-10 17:46:08]

https://codereview.chromium.org/753543003/diff/60001/gyp/android_output.gyp
File gyp/android_output.gyp (right):

https://codereview.chromium.org/753543003/diff/60001/gyp/android_output.gyp#n...
gyp/android_output.gyp:1: # GYP file to send android SkDebug to stdout. To
enable, include this project
...SkDebug both android's logcat and stdout...

[scroggo, 2014-12-10 18:13:24]

https://codereview.chromium.org/753543003/diff/60001/gyp/android_output.gyp
File gyp/android_output.gyp (right):

https://codereview.chromium.org/753543003/diff/60001/gyp/android_output.gyp#n...
gyp/android_output.gyp:1: # GYP file to send android SkDebug to stdout. To
enable, include this project
On 2014/12/10 17:46:08, djsollen wrote:
> ...SkDebug both android's logcat and stdout...

Done.

[scroggo, 2014-12-10 18:13:33]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-12-10 18:14:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753543003/80001

[commit-bot: I haz the power, 2014-12-10 18:23:11]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6cfce1b7b4ad546b02823a1a0bbbda2c17b688f5