src/heap/store-buffer.cc - Issue 753503002: Enable inobject double fields unboxing for 64-bit archs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/store-buffer.cc

Issue 753503002: Enable inobject double fields unboxing for 64-bit archs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Windows build fixed Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/store-buffer.cc

diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc

index 4b94a95761774a05d3b44affed0b510caec4bbcd..5fd4ce34f3aee6913c42fe3c292b1dea5f0ea8ab 100644

--- a/src/heap/store-buffer.cc

+++ b/src/heap/store-buffer.cc

@@ -519,7 +519,7 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback,

if (!has_only_tagged_fields) {

for (Address slot = start_address; slot < end_address;

slot += kPointerSize) {

- if (helper.IsTagged(slot - obj_address)) {

+ if (helper.IsTagged(static_cast<int>(slot - obj_address))) {

// TODO(ishell): call this once for contiguous region

// of tagged fields.

FindPointersToNewSpaceInRegion(slot, slot + kPointerSize,

« no previous file with comments | « src/heap/mark-compact.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »