Issue 753503002: Enable inobject double fields unboxing for 64-bit archs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 753503002: Enable inobject double fields unboxing for 64-bit archs. (Closed)

Created:
6 years, 1 month ago by Igor Sheludko

Modified:
6 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Enable inobject double fields unboxing for 64-bit archs.

Patch Set 1 #

Patch Set 2 : Comma at the end of enum list removed #

Patch Set 3 : Windows build fixed #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	src/globals.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/mark-compact.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap/store-buffer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-unboxed-doubles.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753503002/40001

6 years, 1 month ago (2014-11-22 17:02:48 UTC) #5

Igor Sheludko

6 years, 1 month ago (2014-11-22 20:32:23 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/751863002/ by ishell@chromium.org.

The reason for reverting is: GCMole and gc-stress issues..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages