Issue 753453002: Convert xmlhttprequest.sky to use classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 753453002: Convert xmlhttprequest.sky to use classes (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Convert xmlhttprequest.sky to use classes R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b3e4dc4fb71d3f90171179816c964c1c2b6095c

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -47 lines)			Patch
	M	sky/framework/xmlhttprequest.sky	View		1 chunk	+52 lines, -47 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm https://codereview.chromium.org/753453002/diff/1/sky/framework/xmlhttprequest.sky File sky/framework/xmlhttprequest.sky (right): https://codereview.chromium.org/753453002/diff/1/sky/framework/xmlhttprequest.sky#newcode16 sky/framework/xmlhttprequest.sky:16: this.responseText = null; It might be nice to ...

6 years, 1 month ago (2014-11-21 07:24:24 UTC) #2

abarth-chromium

6 years, 1 month ago (2014-11-21 07:27:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b3e4dc4fb71d3f90171179816c964c1c2b6095c (presubmit successful).

Expand Messages | Collapse Messages