Add flag for single click autofill

Add flag for single click autofill.

This currently defaults to off and if enabled will show suggestions when the mouse is first clicked in an edit box.

Converts ShowSuggestions function call which took 6 bool parameters to take a struct for clarity and future enhancement.

Committed: https://crrev.com/b505b7a590a859d870d267f440dc9c071b4cd5db
Cr-Commit-Position: refs/heads/master@{#305889}

[brettw, 2014-11-25 17:58:30]

brettw@chromium.org changed reviewers:
+ estade@chromium.org

[brettw, 2014-11-25 18:08:56]

I started tweaking the parameters to ShowAutofill to try to make the
single-click popup smarter. I backed off on this and will consider that in a
future patch, but I kept the refactor of the ShowAutofill parameters because
they're out of control.

[please use gerrit instead, 2014-11-25 18:38:21]

FYI, new entries in about_flags.cc need corresponding entries in
tools/metrics/histograms/histograms.xml. You can run "out/Release/unit_tests
--gtest_filter='*AboutFlagsHistogramTest*'" to print out the line that needs to
be added to histograms.xml. After you add this line to histograms.xml, you can
run tools/metrics/histograms/pretty_print.py to fix up histograms.xml format.

[Evan Stade, 2014-11-25 20:50:14]

could you add BUG=427660 to the description?

lgtm with update to histograms.xml

https://codereview.chromium.org/753393004/diff/40001/components/autofill/cont...
File components/autofill/content/renderer/autofill_agent.h (right):

https://codereview.chromium.org/753393004/diff/40001/components/autofill/cont...
components/autofill/content/renderer/autofill_agent.h:57: // Flags passed to
ShowSuggestions.
nice

[brettw, 2014-11-26 01:10:11]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-26 01:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753393004/60001

[commit-bot: I haz the power, 2014-11-26 01:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-26 01:17:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2014-11-26 17:43:18]

brettw@chromium.org changed reviewers:
+ isherman@chromium.org

[brettw, 2014-11-26 17:43:19]

isherman: histogram owners review.

[Ilya Sherman, 2014-11-26 20:58:13]

histograms.xml lgtm

[Ilya Sherman, 2014-11-26 20:58:21]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-11-26 20:59:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753393004/60001

[commit-bot: I haz the power, 2014-11-26 22:05:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-26 22:06:34]

Patchset 4 (id:??) landed as
https://crrev.com/b505b7a590a859d870d267f440dc9c071b4cd5db
Cr-Commit-Position: refs/heads/master@{#305889}