Add GetIdentityHash to v8::Name object API

Add GetIdentityHash to v8::Name object API

v8::Object already has GetIdentityHash on it. This change adds its counterpart to v8::Name.

BUG=chromium:437416
LOG=Y

[yurys, 2014-12-01 15:26:22]

yurys@chromium.org changed reviewers:
+ aandrey@chromium.org, adamk@chromium.org, yangguo@chromium.org

[aandrey, 2014-12-01 15:49:17]

https://codereview.chromium.org/753373003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/753373003/diff/1/include/v8.h#newcode1827
include/v8.h:1827: * uses a inline property on the object to store the identity
hash.
a inline -> an inline

https://codereview.chromium.org/753373003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
why checking self->HasHashCode()?
just remove this DCHECK?

https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:3047: CHECK_EQ(hash, hash3);
can you also test symbols from JS:

v8::Handle<Value> js_symbol = CompileRun("Symbol('foo')");

[Yang, 2014-12-02 07:55:44]

LGTM once all comments are addressed.

https://codereview.chromium.org/753373003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
On 2014/12/01 15:49:17, aandrey wrote:
> why checking self->HasHashCode()?
> just remove this DCHECK?

agree.

[yurys, 2014-12-02 08:42:31]

https://codereview.chromium.org/753373003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/753373003/diff/1/include/v8.h#newcode1827
include/v8.h:1827: * uses a inline property on the object to store the identity
hash.
On 2014/12/01 15:49:17, aandrey wrote:
> a inline -> an inline

Done.

https://codereview.chromium.org/753373003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
On 2014/12/01 15:49:17, aandrey wrote:
> why checking self->HasHashCode()?
> just remove this DCHECK?

Done.

https://codereview.chromium.org/753373003/diff/1/src/api.cc#newcode4240
src/api.cc:4240: DCHECK(!self->IsSymbol() || self->HasHashCode());
On 2014/12/02 07:55:44, Yang wrote:
> On 2014/12/01 15:49:17, aandrey wrote:
> > why checking self->HasHashCode()?
> > just remove this DCHECK?
> 
> agree.

Done.

https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/753373003/diff/1/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:3047: CHECK_EQ(hash, hash3);
On 2014/12/01 15:49:17, aandrey wrote:
> can you also test symbols from JS:
> 
> v8::Handle<Value> js_symbol = CompileRun("Symbol('foo')");

Done.

[yurys, 2014-12-02 08:45:01]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-12-02 08:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753373003/20001

[aandrey, 2014-12-02 09:06:14]

LGTM!

[commit-bot: I haz the power, 2014-12-02 09:13:25]

Committed patchset #2 (id:20001)