Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 753313005: Revert of Re-land chromeos: Add non-extension renderers to the freezer cgroup (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
CC:
chromium-reviews, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, Sameer Nanda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land chromeos: Add non-extension renderers to the freezer cgroup (patchset #3 id:40001 of https://codereview.chromium.org/738993002/) Reason for revert: Crashes (especially on login) BUG=364339, 437962 Original issue's description: > Re-land chromeos: Add non-extension renderers to the freezer cgroup > > In preparation for lucid sleep, we will be putting all chrome renderers > that do not host GCM extensions into a special freezer cgroup. All > processes in this cgroup will be frozen when the system suspends and > will not be thawed until the system has fully resumed. > > The code to freeze and thaw the cgroup has existed for a while. This > code actually starts putting processes into the cgroup. > > Additionally, to deal with potential races that may occur with other > suspend observers that interact with renderers, the RendererFreezer is > no longer a PowerManagerClient::Observer but is instead a > PowerManagerClient::RenderProcessManagerDelegate. This guarantees that > the RendererFreezer's suspend related methods will be called only after > all observers have reported ready and before observers are notified that > the suspend has completed. Any race conditions that still exist now > need to be fixed in the observer that is causing it. > > BUG=364339 > > Committed: https://crrev.com/1a085efa9263279b58d6fd06ba991709d598f796 > Cr-Commit-Position: refs/heads/master@{#304956} TBR=derat@chromium.org,chirantan@chromium.org NOTREECHECKS=true NOTRY=true BUG=364339 Committed: https://crrev.com/387356b291bfb0e278bb350e0d1e492107a292e4 Cr-Commit-Position: refs/heads/master@{#306269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -491 lines) Patch
M chrome/browser/chromeos/power/freezer_cgroup_process_manager.h View 2 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc View 4 chunks +13 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/power/renderer_freezer.h View 3 chunks +14 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/power/renderer_freezer.cc View 3 chunks +28 lines, -124 lines 0 comments Download
M chrome/browser/chromeos/power/renderer_freezer_unittest.cc View 8 chunks +51 lines, -207 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 2 chunks +0 lines, -22 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 5 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
spang
Created Revert of Re-land chromeos: Add non-extension renderers to the freezer cgroup
6 years ago (2014-12-01 22:19:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753313005/1
6 years ago (2014-12-01 22:20:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 22:21:25 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-01 22:22:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/387356b291bfb0e278bb350e0d1e492107a292e4
Cr-Commit-Position: refs/heads/master@{#306269}

Powered by Google App Engine
This is Rietveld 408576698