Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 753313002: fix for the msvs gyp generator that produces nonposix path separators (Closed)

Created:
6 years ago by djsollen
Modified:
6 years ago
Reviewers:
borenet, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix for the msvs gyp generator that produces nonposix path separators BUG=skia:3139 Committed: https://skia.googlesource.com/skia/+/6f78a6448b8532722eeb8ce1191caa1c3a999df8

Patch Set 1 #

Patch Set 2 : attempt 2 #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M tools/generate_includes_cpp.py View 1 2 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
djsollen
robert, can you patch this on your machine and give it a shot?
6 years ago (2014-11-24 20:29:01 UTC) #2
djsollen
this last patch set should be good to go. Adding Eric to sanity check my ...
6 years ago (2014-11-25 15:56:18 UTC) #4
robertphillips
lgtm. I have verified that it works in MSVC.
6 years ago (2014-11-25 16:05:04 UTC) #5
borenet
Python LGTM
6 years ago (2014-11-25 16:14:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753313002/40001
6 years ago (2014-11-25 16:15:28 UTC) #8
commit-bot: I haz the power
6 years ago (2014-11-25 16:25:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6f78a6448b8532722eeb8ce1191caa1c3a999df8

Powered by Google App Engine
This is Rietveld 408576698