Remove a condition to prevent focus on captured window.

Remove a condition to prevent focus on captured window.

As I commented on the issue 402272, this condition was added
to prevent fullscreen cancel when a context menu window
comes up (see crbug.com/174731 for the details). However,
that bug doesn't make sense because fullscreen isn't
cancelled anymore when another window gets the focus.

R=sky@chromium.org
TEST=manually -- see the bug line. Also this doesn't make regression on crbug.com/174731 with http://www.flashvideofactory.com/test/demofullscreen345.html
BUG=402272
Committed: https://crrev.com/63839ef7ef0a2cf2e79befe292d12b2c06191299
Cr-Commit-Position: refs/heads/master@{#307518}

[Jun Mukai, 2014-12-01 18:51:43]

mukai@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-12-02 23:43:17]

How about a test that ensure we have the logic needed by tab dragging? That way
if someone adds this bad we'll know.

[Jun Mukai, 2014-12-03 22:51:49]

On 2014/12/02 23:43:17, sky wrote:
> How about a test that ensure we have the logic needed by tab dragging? That
way
> if someone adds this bad we'll know.

That sounds a good idea, however I've noticed that the test case in
tab_dragging_controller is disabled for chromeos because of crbug.com/331924
I wrote https://codereview.chromium.org/773293002/ which would verify the
expected behavior, however it succeeds on Windows without this CL (because, I
guess, each browser window is hosted by a root window in Windows).

Do you have recommendations?  Can I add these expectations?

[sky, 2014-12-03 22:56:52]

I would prefer a more focused test. It's less likely to get disabled
as seems to happen with the tab dragging tests.

  -Scott

On Wed, Dec 3, 2014 at 2:51 PM,  <mukai@chromium.org> wrote:
> On 2014/12/02 23:43:17, sky wrote:
>>
>> How about a test that ensure we have the logic needed by tab dragging?
>> That
>
> way
>>
>> if someone adds this bad we'll know.
>
>
> That sounds a good idea, however I've noticed that the test case in
> tab_dragging_controller is disabled for chromeos because of crbug.com/331924
> I wrote https://codereview.chromium.org/773293002/ which would verify the
> expected behavior, however it succeeds on Windows without this CL (because,
> I
> guess, each browser window is hosted by a root window in Windows).
>
> Do you have recommendations?  Can I add these expectations?
>
> https://codereview.chromium.org/753223004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jun Mukai, 2014-12-09 01:07:56]

Added the test case. PTAL.

[sky, 2014-12-09 16:32:29]

LGTM

[Jun Mukai, 2014-12-09 18:19:08]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-12-09 18:19:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/753223004/60001

[commit-bot: I haz the power, 2014-12-09 19:32:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-09 19:33:27]

Patchset 4 (id:??) landed as
https://crrev.com/63839ef7ef0a2cf2e79befe292d12b2c06191299
Cr-Commit-Position: refs/heads/master@{#307518}