Issue 753213003: Adding a new enum "MEDIA_CODEC_ABORT" for aborted cases

Issue 753213003: Adding a new enum "MEDIA_CODEC_ABORT" for aborted cases (Closed)

Created:
6 years ago by anujsharma

Modified:
6 years ago

Reviewers:
qinmin, xhwang

CC:
chromium-reviews, MRV

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Adding a new enum "MEDIA_CODEC_ABORT" for aborted cases BUG= Committed: https://crrev.com/6aa4f8b3b9092b4274d28ae364200a55e966225b Cr-Commit-Position: refs/heads/master@{#306970}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
M	media/base/android/java/src/org/chromium/media/MediaCodecBridge.java	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/android/media_codec_bridge.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/android/media_decoder_job.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/android/media_decoder_job.cc	View	1 2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
M	media/base/android/media_source_player.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 11 (2 generated)

qinmin

MEDIA_CODEC_STOPPED is not used anywhere, i think you can just rename that enum to ABORT

6 years ago (2014-12-03 16:34:07 UTC) #3

anujsharma

On 2014/12/03 16:34:07, qinmin wrote: > MEDIA_CODEC_STOPPED is not used anywhere, i think you can ...

6 years ago (2014-12-04 07:11:42 UTC) #4

anujsharma

On 2014/12/04 19:15:38, qinmin wrote: > lgtm Thanks qinmin for lgtm.

6 years ago (2014-12-05 02:50:18 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753213003/60001

6 years ago (2014-12-05 02:51:37 UTC) #9

commit-bot: I haz the power

6 years ago (2014-12-05 03:51:50 UTC) #11

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/6aa4f8b3b9092b4274d28ae364200a55e966225b
Cr-Commit-Position: refs/heads/master@{#306970}