Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 753173002: Preparation steps for adding speculative renderer creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor missing things. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 7ab54bf0cab318432f04509f45773d236b9ffafb..9e250963a8421e3fc9aa0ca24aae7b19c19839b7 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3908,10 +3908,13 @@ WebPreferences WebContentsImpl::ComputeWebkitPrefs() {
int WebContentsImpl::CreateSwappedOutRenderView(
SiteInstance* instance) {
- return GetRenderManager()->CreateRenderFrame(
- instance, MSG_ROUTING_NONE, CREATE_RF_SWAPPED_OUT |
- CREATE_RF_FOR_MAIN_FRAME_NAVIGATION |
- CREATE_RF_HIDDEN);
+ int render_view_routing_id = MSG_ROUTING_NONE;
+ GetRenderManager()->CreateRenderFrame(
+ instance, MSG_ROUTING_NONE,
+ CREATE_RF_SWAPPED_OUT | CREATE_RF_FOR_MAIN_FRAME_NAVIGATION |
+ CREATE_RF_HIDDEN,
+ nullptr, &render_view_routing_id);
+ return render_view_routing_id;
}
void WebContentsImpl::OnUserGesture() {
@@ -4083,9 +4086,12 @@ int WebContentsImpl::CreateOpenerRenderViews(SiteInstance* instance) {
// Create a swapped out RenderView in the given SiteInstance if none exists,
// setting its opener to the given route_id. Return the new view's route_id.
- return GetRenderManager()->CreateRenderFrame(
+ int render_view_routing_id = MSG_ROUTING_NONE;
+ GetRenderManager()->CreateRenderFrame(
instance, opener_route_id, CREATE_RF_FOR_MAIN_FRAME_NAVIGATION |
- CREATE_RF_SWAPPED_OUT | CREATE_RF_HIDDEN);
+ CREATE_RF_SWAPPED_OUT | CREATE_RF_HIDDEN,
+ nullptr, &render_view_routing_id);
+ return render_view_routing_id;
}
NavigationControllerImpl& WebContentsImpl::GetControllerForRenderManager() {

Powered by Google App Engine
This is Rietveld 408576698