Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 753113003: Disabling AX test for select.html. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disabling AX test for select.html. This will be enabled once this change rolls in https://codereview.chromium.org/753123002/ BUG=169564 Committed: https://crrev.com/083db2fb0036ea53c9183970c936ab93c6c472ec Cr-Commit-Position: refs/heads/master@{#305446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-11-24 10:34:11 UTC) #2
shreeramk
On 2014/11/24 10:34:11, shreeramk wrote: > Please review. > > Thanks!! I submitted this CL, ...
6 years ago (2014-11-24 11:04:07 UTC) #3
dmazzoni
lgtm When you land a change in Blink (in third-party/WebKit), it doesn't "roll" to Chromium ...
6 years ago (2014-11-24 17:38:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753113003/1
6 years ago (2014-11-24 17:39:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-24 18:20:39 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/083db2fb0036ea53c9183970c936ab93c6c472ec Cr-Commit-Position: refs/heads/master@{#305446}
6 years ago (2014-11-24 18:21:16 UTC) #8
shreeramk
6 years ago (2014-11-25 05:09:58 UTC) #9
Message was sent while issue was closed.
On 2014/11/24 17:38:53, dmazzoni wrote:
> lgtm
> 
> When you land a change in Blink (in third-party/WebKit), it doesn't "roll" to
> Chromium for a few hours, so the tests aren't run and won't fail right away.
> That's why you didn't see the test failure.
> 
> Before the roll, the tests are all run, and if the test fails, your Blink
change
> would be reverted and you'd have to try again.

But, I had ran the bots for *_chromium_rel in this CL...then it should have
failed. Isn't??

Powered by Google App Engine
This is Rietveld 408576698