Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 753113002: Encode super calls via extra properties on prototypes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index 4eff34a459a1a27cfae6151df1b119eab7803b15..0fe858bd225d1be9097935c12a968c4d74cf2962 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -220,6 +220,7 @@ class Namer implements ClosureNamer {
final String currentIsolate = r'$';
final String getterPrefix = r'get$';
final String setterPrefix = r'set$';
+ final String superPrefix = r'super$';
final String metadataField = '@';
final String callPrefix = 'call';
final String callCatchAllName = r'call$catchAll';
@@ -809,6 +810,14 @@ class Namer implements ClosureNamer {
// TODO(ahe): Remove this method. Use get getNameOfMember instead.
String getNameOfInstanceMember(Element member) => getNameX(member);
+ String getNameOfAliasedSuperMember(Element member) {
+ ClassElement superClass = member.enclosingClass;
+ String className = getNameOfClass(superClass);
+ String memberName = getNameOfMember(member);
+ String proposal = "$superPrefix$className\$$memberName";
+ return getMappedInstanceName(proposal);
sra1 2014/11/25 18:02:48 Maybe add a TODO. Since super aliases are always k
herhut 2014/11/26 09:41:36 Thanks! Great catch! Done.
+ }
+
String getNameOfMember(Element member) => getNameX(member);
String getNameOfGlobalField(VariableElement field) => getNameX(field);
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698