Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 753073009: [turbofan] Avoid repeatedly revisiting inputs in GraphReducer. (Closed)

Created:
6 years ago by titzer
Modified:
6 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid repeatedly revisiting inputs in GraphReducer. R=mstarzinger@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M src/compiler/graph-reducer.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 2 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
6 years ago (2014-11-27 15:31:31 UTC) #1
Michael Starzinger
LGTM, just one nit. https://codereview.chromium.org/753073009/diff/1/src/compiler/graph-reducer.cc File src/compiler/graph-reducer.cc (right): https://codereview.chromium.org/753073009/diff/1/src/compiler/graph-reducer.cc#newcode182 src/compiler/graph-reducer.cc:182: stack_.push(entry); nit: Can we use ...
6 years ago (2014-11-27 15:46:34 UTC) #2
titzer
On 2014/11/27 15:46:34, Michael Starzinger wrote: > LGTM, just one nit. > > https://codereview.chromium.org/753073009/diff/1/src/compiler/graph-reducer.cc > ...
6 years ago (2014-11-27 15:55:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/753073009/40001
6 years ago (2014-11-27 15:56:45 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-27 16:24:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698