Issue 7530024: bookmarks: Simplify is_permanent_node() implementation.

Issue 7530024: bookmarks: Simplify is_permanent_node() implementation. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

bookmarks: Simplify is_permanent_node() implementation. BUG=None TEST=None R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94756

Patch Set 9 : sky review -> is_root_node #

Total comments: 2

Patch Set 10 : use is_root_node #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -29 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model.h	View	1 2 3 4 5 6 7 8	2 chunks	+13 lines, -21 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	1 2 3 4 5 6 7 8	7 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/7530024/diff/8001/chrome/browser/bookmarks/bookmark_model.h File chrome/browser/bookmarks/bookmark_model.h (left): http://codereview.chromium.org/7530024/diff/8001/chrome/browser/bookmarks/bookmark_model.h#oldcode307 chrome/browser/bookmarks/bookmark_model.h:307: bool is_root(const BookmarkNode* node) const { return node == ...

9 years, 4 months ago (2011-07-29 18:08:27 UTC) #2

tfarina

9 years, 4 months ago (2011-07-29 18:22:54 UTC) #3

sky

LGTM http://codereview.chromium.org/7530024/diff/6005/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right): http://codereview.chromium.org/7530024/diff/6005/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm#newcode381 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:381: if (parent != model_->root_node()) { Use is_root_node

9 years, 4 months ago (2011-07-29 19:30:28 UTC) #4

tfarina

9 years, 4 months ago (2011-07-29 19:39:36 UTC) #5

http://codereview.chromium.org/7530024/diff/6005/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

http://codereview.chromium.org/7530024/diff/6005/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:381: if (parent
!= model_->root_node())  {
On 2011/07/29 19:30:28, sky wrote:
> Use is_root_node

Done.

Expand Messages | Collapse Messages