Re-design the "data" tab on about:net-internals.

Re-design the "data" tab on about:net-internals.

Split it up into three separate tabs: "Import", "Export", and "Capture".

This keeps them visually simpler, and leaves space for more options on each.

When loading a file, the "Capture" and "Export" tabs are hidden.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94670

[eroman, 2011-07-29 01:08:08]

Here is what it looks like:

Capture tab: http://i.imgur.com/aKyav.png
Capture tab (with expanded tip): http://i.imgur.com/d4D99.png
Import tab: http://imgur.com/iBwST
Export tab: http://i.imgur.com/kwAMy.png

There is a subtle change in behavior from before: while a file is being saved,
the load button is not disbled (and vice versa). This is an implementation
detail with how I split the views... I didn't feel it was worth addressing.

[mmenke, 2011-07-29 14:18:53]

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/export_view.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:3: <div
id=dataViewDumpDataDiv>
Not using this anymore, so can delete it or at least remove the id, unless you
think we'll be needing it in the future (And the corresponding const line in the
js file).

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:22: </ul>
Superfluous close tag

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:24: </p>
These tags aren't needed.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/export_view.js (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.js:29: this.dumpDataDiv_ =
$(dumpDataDivId);
nit:  Not used, so can delete, unless you think we'll be using it in the future.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.js:57: return true;
Exporting a loaded log will not work.  Currently, it looks to me like the save
file button will just be disabled eternally, and say "Preparing data...".  I'm
ok with just adding a TODO about it.  Or could just hide this tab.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/import_view.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/import_view.html:5: <p
id=dataViewLoadedClientInfoText></p>
Could you switch this to a pre while you're modifying this file?

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.html:22: Recording network
events...
Thinking there's not enough space for event counts here?  I thought it was a
good idea.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/util.js (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/util.js:45: debugger;
What's this for, exactly?  Break into the debugger when hiding the import tab?

[eroman, 2011-07-29 15:15:08]

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/export_view.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:3: <div
id=dataViewDumpDataDiv>
On 2011/07/29 14:18:53, Matt Menke wrote:
> Not using this anymore, so can delete it or at least remove the id, unless you
> think we'll be needing it in the future (And the corresponding const line in
the
> js file).

Done.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:22: </ul>
On 2011/07/29 14:18:53, Matt Menke wrote:
> Superfluous close tag

oops!

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.html:24: </p>
On 2011/07/29 14:18:53, Matt Menke wrote:
> These tags aren't needed.

Done.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/export_view.js (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.js:29: this.dumpDataDiv_ =
$(dumpDataDivId);
On 2011/07/29 14:18:53, Matt Menke wrote:
> nit:  Not used, so can delete, unless you think we'll be using it in the
future.

Done.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/export_view.js:57: return true;
On 2011/07/29 14:18:53, Matt Menke wrote:
> Exporting a loaded log will not work.  Currently, it looks to me like the save
> file button will just be disabled eternally, and say "Preparing data...".  I'm
> ok with just adding a TODO about it.  Or could just hide this tab.

Oh weird!

So I actually did test that the export tab is hidden during import before
sending this CL. The interesting thing here is this onLoadLogFinish() method is
actually defined on the defunct DataView object, which is why it wasn't having
an effect (and default of hidden was being assumed). Surprisingly this did not
cause any javascript errors.

Done. Fixed it up to be a return false on ExportView.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/import_view.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/import_view.html:5: <p
id=dataViewLoadedClientInfoText></p>
On 2011/07/29 14:18:53, Matt Menke wrote:
> Could you switch this to a pre while you're modifying this file?

Done.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/index.html (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/index.html:22: Recording network
events...
On 2011/07/29 14:18:53, Matt Menke wrote:
> Thinking there's not enough space for event counts here?  I thought it was a
> good idea.

Yeah I wasn't sure about this. Having the entire Capture tab to display this
information, I wasn't sure it was a win to mirror it in the status bar where
there isn't much room to explain it.

I do like the "animated" effect of having a counter in the status area though,
it emphasizes that stuff is happening.

Dunno, I can re-visit this later after some more experiments, for now I decided
to remove the TODO since there is a chance I will not do it.

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/util.js (right):

http://codereview.chromium.org/7530020/diff/2002/chrome/browser/resources/net...
chrome/browser/resources/net_internals/util.js:45: debugger;
On 2011/07/29 14:18:53, Matt Menke wrote:
> What's this for, exactly?  Break into the debugger when hiding the import tab?

Oops, that was left-over from my debugging session! (Removed).

I was trying to figure out why the "Import" tab was getting hidden after I
loaded a file. Turned out the try/catch block around onLoadLogFinish was
swallowing a javascript error in my refactor.

[mmenke, 2011-07-29 15:20:02]

LGTM