Issue 752983002: Deflake appCache/fail-on-update* by removing sync XMLHTTPRequest warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 752983002: Deflake appCache/fail-on-update* by removing sync XMLHTTPRequest warnings (Closed)

Created:
6 years, 1 month ago by pdr.

Modified:
6 years, 1 month ago

Reviewers:

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Deflake appCache/fail-on-update* by removing sync XMLHTTPRequest warnings The fail-on-update tests currently output warnings due to synchronous XMLHttpRequest usage. These tests can send multiple XMLHttpRequests which causes multiple warnings which makes the tests flaky[1]. This patch refactors these tests to use asynchronous XMLHttpRequest. [1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fail-on-update-2.html TBR=timvolodine,tasak Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185849

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -26 lines)			Patch
M	LayoutTests/http/tests/appcache/fail-on-update.html	View	4 chunks	+20 lines, -10 lines	0 comments	Download
M	LayoutTests/http/tests/appcache/fail-on-update-2.html	View	4 chunks	+23 lines, -13 lines	0 comments	Download
M	LayoutTests/http/tests/appcache/fail-on-update-2-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/appcache/fail-on-update-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/752983002/1

6 years, 1 month ago (2014-11-22 23:23:00 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-23 00:32:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185849