Rename NET_API to NET_EXPORT, and rename NET_TEST to NET_EXPORT_PRIVATE.

net/base/net_export.h

Index: net/base/net_export.h
===================================================================
--- net/base/net_export.h	(revision 95949)
+++ net/base/net_export.h	(working copy)
@@ -2,33 +2,33 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef NET_BASE_NET_API_H_
-#define NET_BASE_NET_API_H_
+#ifndef NET_BASE_NET_EXPORT_H_
+#define NET_BASE_NET_EXPORT_H_
 #pragma once
 
-// Defines NET_API so that functionality implemented by the net module can be
-// exported to consumers, and NET_TEST that allows unit tests to access features
-// not intended to be used directly by real consumers.
+// Defines NET_EXPORT so that functionality implemented by the net module can
+// be exported to consumers, and NET_EXPORT_PRIVATE that allows unit tests to
+// access features not intended to be used directly by real consumers.
 
 #if defined(COMPONENT_BUILD)
 #if defined(WIN32)
 
 #if defined(NET_IMPLEMENTATION)
-#define NET_API __declspec(dllexport)
-#define NET_TEST __declspec(dllexport)
+#define NET_EXPORT __declspec(dllexport)
+#define NET_EXPORT_PRIVATE __declspec(dllexport)
 #else
-#define NET_API __declspec(dllimport)
-#define NET_TEST __declspec(dllimport)
+#define NET_EXPORT __declspec(dllimport)
+#define NET_EXPORT_PRIVATE __declspec(dllimport)
 #endif  // defined(NET_IMPLEMENTATION)

[wtc, 2011/08/11 18:51:49]

The reason these macros are named XXX_API is that they
are defined as either __declspec(dllexport) or
__declspec(dllimport).

To a programmer familiar with Windows, an XXX_EXPORT macro
seems to imply __declspec(dllexport).

Are you avoiding the use of "API" deliberately?
XXX_API and XXX_API_PRIVATE sound fine to me.

 
 #else  // defined(WIN32)
-#define NET_API __attribute__((visibility("default")))
-#define NET_TEST __attribute__((visibility("default")))
+#define NET_EXPORT __attribute__((visibility("default")))
+#define NET_EXPORT_PRIVATE __attribute__((visibility("default")))
 #endif
 
 #else  /// defined(COMPONENT_BUILD)
-#define NET_API
-#define NET_TEST
+#define NET_EXPORT
+#define NET_EXPORT_PRIVATE
 #endif
 
-#endif  // NET_BASE_NET_API_H_
+#endif  // NET_BASE_NET_EXPORT_H_