pkg/analysis_server/test/services/completion/completion_test_util.dart - Issue 752833002: refactor import caching to exclude suggestions for inherited members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 752833002: refactor import caching to exclude suggestions for inherited members (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: cleanup unused imports Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart ('k') | pkg/analysis_server/test/services/completion/imported_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_test_util.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart

index c351d4b2ffaf309963d6ee6b0104340d0653e763..ffe3bcfafd7ba7575fddb2e560c056cf2d3aa0d4 100644

--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart

+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart

@@ -9,6 +9,7 @@ import 'dart:async';

import 'package:analysis_server/src/protocol.dart' as protocol show Element,

ElementKind;

import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;

+import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';

import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';

import 'package:analysis_server/src/services/completion/imported_computer.dart';

import 'package:analysis_server/src/services/completion/invocation_computer.dart';

@@ -24,6 +25,12 @@ import 'package:unittest/unittest.dart';

import '../../abstract_context.dart';

+int suggestionComparator(CompletionSuggestion s1, CompletionSuggestion s2) {

+ String c1 = s1.completion.toLowerCase();

+ String c2 = s2.completion.toLowerCase();

+ return c1.compareTo(c2);

abstract class AbstractCompletionTest extends AbstractContextTest {

Index index;

SearchEngineImpl searchEngine;

@@ -471,11 +478,7 @@ abstract class AbstractCompletionTest extends AbstractContextTest {

if (completions != null) {

sb.write('\n found');

completions.toList()

- ..sort((CompletionSuggestion s1, CompletionSuggestion s2) {

- String c1 = s1.completion.toLowerCase();

- String c2 = s2.completion.toLowerCase();

- return c1.compareTo(c2);

- })

+ ..sort(suggestionComparator)

..forEach((CompletionSuggestion suggestion) {

sb.write('\n ${suggestion.completion} -> $suggestion');

});