Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 752833002: refactor import caching to exclude suggestions for inherited members (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cleanup unused imports Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
index d2f6c1127e1ec142f39f6b0f991b5b847a095dfa..217ee6cdc407bdf54bb44fced4b53244e05b7fe5 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
@@ -10,6 +10,7 @@ import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/services/completion/arglist_computer.dart';
import 'package:analysis_server/src/services/completion/combinator_computer.dart';
import 'package:analysis_server/src/services/completion/completion_manager.dart';
+import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';
import 'package:analysis_server/src/services/completion/imported_computer.dart';
import 'package:analysis_server/src/services/completion/invocation_computer.dart';
import 'package:analysis_server/src/services/completion/keyword_computer.dart';
@@ -21,45 +22,6 @@ import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
/**
- * The `DartCompletionCache` contains cached information from a prior code
- * completion operation.
- */
-class DartCompletionCache extends CompletionCache {
-
- /**
- * A hash of the import directives.
- */
- String importKey;
-
- /**
- * Library prefix suggestions based upon imports,
- * or `null` if nothing has been cached.
- */
- List<CompletionSuggestion> libraryPrefixSuggestions;
-
- /**
- * Type suggestions based upon imports,
- * or `null` if nothing has been cached.
- */
- List<CompletionSuggestion> importedTypeSuggestions;
-
- /**
- * Suggestions for methods and functions that have void return type,
- * or `null` if nothing has been cached.
- */
- List<CompletionSuggestion> importedVoidReturnSuggestions;
-
- /**
- * Other suggestions based upon imports,
- * or `null` if nothing has been cached.
- */
- List<CompletionSuggestion> otherImportedSuggestions;
-
- DartCompletionCache(AnalysisContext context, Source source)
- : super(context, source);
-}
-
-/**
* The base class for computing code completion suggestions.
*/
abstract class DartCompletionComputer {

Powered by Google App Engine
This is Rietveld 408576698